Skip to content

feat(skills): add coding-guidelines skill and consolidate PR guidance - #272

Merged
demandal25 merged 2 commits into
amd-integrationfrom
coding-workflow-skill
Jul 29, 2026
Merged

feat(skills): add coding-guidelines skill and consolidate PR guidance#272
demandal25 merged 2 commits into
amd-integrationfrom
coding-workflow-skill

Conversation

@demandal25

@demandal25 demandal25 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Two skill/docs changes: adds a new coding-guidelines skill, and consolidates the project's PR mechanics into the pr-workflow skill (moving them out of CLAUDE.md) so they live in one place and are followed consistently.

What changed

  • .claude/skills/coding-guidelines/SKILL.md — new skill: YAML frontmatter (name / description) plus four numbered sections — Think Before Coding, Simplicity First, Surgical Changes, and Goal-Driven Execution. Mirrors the existing plan-review skill so the two read consistently.
  • .claude/skills/pr-workflow/SKILL.md — absorbs the branch-naming and ask-before-pushing rules from CLAUDE.md, and gains PR body-formatting rules: do not hard-wrap PR bodies (GitHub renders a single newline as <br>), and do not append a "Generated with Claude Code" footer.
  • CLAUDE.md — drops the now-relocated branch-naming and ask-before-pushing sections, keeping it lean and pointing at the pr-workflow skill.

Test plan

  • Skill/docs-only change — no Python code paths touched, so there are no relevant pytests to run.
  • pre-commit run --files on all three changed files — all applicable hooks pass (markdownlint included). These scoped runs cover the branch's entire diff; a full pre-commit run -a is impractically slow over the whole repo and not meaningful for markdown-only changes.

Copilot AI review requested due to automatic review settings July 29, 2026 16:50
@demandal25
demandal25 force-pushed the coding-workflow-skill branch from 05e4545 to 1cdf14c Compare July 29, 2026 16:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands ROCm batch-decode support by enabling opt-in CUDA-graph capture for the AITER batch-decode path (explicit backend="aiter" with a capture-at-max contract), adds tests + benchmarks for graph replay correctness/perf, and updates documentation/changelog accordingly. Note: the current PR title/description state this is only adding a coding-workflow skill, which does not match the actual diff scope.

Changes:

  • Enable AITER batch-decode under CUDA-graph capture for explicit backend="aiter", replacing the prior hard error with a one-time warning describing the capture-at-max constraint.
  • Add ROCm test coverage for AITER graph replay and add a benchmark script comparing graph replay behavior/performance.
  • Update README/CHANGELOG for the new CUDA-graph/AITER behavior, and add the new .claude coding-workflow skill document.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
flashinfer/decode_rocm.py Allows backend="aiter" with CUDA-graph enabled (warns about capture-at-max constraint instead of raising).
tests/rocm_tests/test_batch_decode_aiter_hip.py Removes the “graph capture rejected” test and adds a positive graph replay correctness test for AITER.
benchmarks/rocm_benchmarks/bench_decode_graph_hip.py Adds an acceptance/timing script for AITER decode under graph capture + replay.
benchmarks/rocm_benchmarks/bench_batch_decode_hip.py Adds/updates eager decode benchmark; docstring needs alignment with new graph behavior.
README.md Documents the new opt-in AITER-under-graph behavior and clarifies auto routing under capture.
CHANGELOG.md Adds a release note entry describing AITER CUDA-graph capture support and associated tests/benchmarks.
.claude/skills/coding-workflow/SKILL.md Adds the new coding-workflow skill content (workflow guidance).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 29, 2026 16:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 29, 2026 17:18
@demandal25
demandal25 force-pushed the coding-workflow-skill branch from 1cdf14c to f6b8f74 Compare July 29, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 29, 2026 17:44
@demandal25 demandal25 changed the title feat(skills): add coding-workflow skill feat(skills): add coding-workflow skill and document PR body formatting Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

demandal25 and others added 2 commits July 29, 2026 13:53
Add a coding-guidelines skill capturing a disciplined implementation
workflow: think before coding, simplicity first, surgical changes, and
goal-driven execution. Structured to mirror the existing plan-review skill.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Move the branch-naming and ask-before-pushing rules out of CLAUDE.md and
into the pr-workflow skill, and record the PR body formatting rules there
(no hard-wrap; no "Generated with Claude Code" footer). Keeps CLAUDE.md
lean and puts all PR mechanics in one skill.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 29, 2026 17:53
@demandal25
demandal25 force-pushed the coding-workflow-skill branch from b5b38ca to 34f8296 Compare July 29, 2026 17:53
@demandal25 demandal25 changed the title feat(skills): add coding-workflow skill and document PR body formatting feat(skills): add coding-guidelines skill and consolidate PR guidance Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.claude/skills/pr-workflow/SKILL.md:209

  • This note says the hard-wrap rule “mirrors the ## PR / issue body formatting rule in CLAUDE.md”, but that section was removed from CLAUDE.md in this PR, so the reference is now stale/inaccurate.
  to separate blocks. (Mirrors the `## PR / issue body formatting` rule in
  CLAUDE.md; note this is the opposite of how the repo's `.md`/`.py` source
  files — including this skill — are wrapped.)

@demandal25
demandal25 merged commit 9cf2aec into amd-integration Jul 29, 2026
2 checks passed
@demandal25
demandal25 deleted the coding-workflow-skill branch July 29, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants