Skip to content

Update TraceLens trace splitter invocations - #119

Merged
haofrank merged 2 commits into
mainfrom
fix/update_trace_splitter_invocations
Oct 14, 2026
Merged

haofrank merged 2 commits into
mainfrom
fix/update_trace_splitter_invocations

Conversation

@kyle-hoffmeyer

@kyle-hoffmeyer kyle-hoffmeyer commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

TraceLens trace splitter invocation methods have been updated: AMD-AGI/TraceLens#1052.

Updating invocations in Magpie

@kyle-hoffmeyer
kyle-hoffmeyer marked this pull request as ready for review October 9, 2026 18:00
@haofrank

Copy link
Copy Markdown
Member

Could we preserve backward compatibility with existing TraceLens installations here by preferring TraceLens_split_trace and falling back to TraceLens_split_inference_trace when the new command is unavailable, for both local and container execution?

The rename is correct for newer TraceLens versions. The potential issue is upgrading Magpie while reusing an older TraceLens installation or cached Docker image: ensure_tracelens_installed() accepts an existing installation without checking for the new splitter command, and runtime preparation can reuse existing TraceLens images without upgrading them. Those environments would then fail during inference postprocessing because they only provide the old command.

Since upstream PR AMD-AGI/TraceLens#1052 preserves the splitter arguments and output format, a legacy-command fallback should keep these existing environments working. If supporting older versions is not intended, an explicit capability check and actionable upgrade/rebuild guidance would help make the new requirement clear.

@kyle-hoffmeyer

Copy link
Copy Markdown
Collaborator Author

@haofrank, thanks for your review. Since the new trace splitter is much more robust and can handle a variety of workloads, it'd be best if users migrate to the new trace splitter. Using the old trace splitter is much more likely to fail and produce incorrect outputs.
If the new trace splitter isn't found, the user will not get a message recommending the user to upgrade to the latest TraceLens release.

@haofrank haofrank left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM

@haofrank
haofrank merged commit 6a1ee26 into main Oct 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants