Repository navigation
ci(release): publish an atom-nightly image for the GLM-5.2 ATOM kit - #214
Merged
Merged
Conversation
The release `atom` image is Dockerfile.atom with its defaults: the ATOM release base and patches/atom/. examples/atom_4p4d_glm5.2 needs the ATOM nightly base with patches/atom_nightly/ (ATOM_NIGHTLY=1, BUILD_MOONCAKE=0), which no release builds, so the kit has no published image. Add an `atom-nightly` engine to build_test_push.sh (same Dockerfile, those three build args) and to release.yml's default engine list, so a release also publishes inferaimage/infera:atom-nightly-<id>. `atom` is unchanged. The kit README, its manual page, the atom_nightly README and the top-level README name the new image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: YaoCheng <Cheng.Yao2@amd.com>
ChengYao-amd
requested review from
jiejingzhangamd,
limou102 and
xiaobochen-amd
as code owners
October 23, 2026 06:06
…engine images Release builds push to the staging repo; rocm/infera only gets the images promoted after review, and not all of them (atom-v0.3.0 was not). The kit README, its manual page and the top-level README said a release publishes rocm/infera:atom-nightly-<version>, which a kit user would then fail to pull. Say releases from v0.3.1 build it and it is on rocm/infera once promoted. Also list the ATOM_NIGHTLY=1 build in the manual's engine image table, drop "ATOM uses a single base image", point the top-level README's build section at the atom_nightly build args, and name the release image in the kit's env.sh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: YaoCheng <Cheng.Yao2@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release
atomimage isDockerfile.atomwith its defaults: the ATOM release base (rocm/atom:…atom0.1.4_20260612) andpatches/atom/. The GLM-5.2 ATOM PD kit (examples/atom_4p4d_glm5.2, #198 / #209) needs the ATOM nightly base withpatches/atom_nightly/:release.ymlpasses no build args to engine images, so no release builds that image. Users of the kit had to build it themselves.What
build_test_push.sh: a newatom-nightlyengine. SameDockerfile.atom, with the three build args above. Tagged<IMAGE>:atom-nightly-<id>like every other engine.release.yml:atom-nightlyadded to the default engine list (tag push and dispatch).atomis unchanged and stays on the release base, whichpatches/atom/(MiniMax, GDN, Mooncake consumer slot) is written for.patches/atom_nightly/README.md(keep the two base pins in step) and the top-level README name the new image.Verification
build_test_push.shdry run with a stubdocker:ID=v0.3.1 build atom-nightly→docker build --network=host --build-arg ATOM_BASE_IMAGE=rocm/atom-dev:nightly_202610131505 --build-arg ATOM_NIGHTLY=1 --build-arg BUILD_MOONCAKE=0 -t docker.io/inferaimage/infera:atom-nightly-v0.3.1 -f deploy/docker/Dockerfile.atom .ID=v0.3.1 build atom/build kvd→ unchanged commands (no build args).PR=999 push atom-nightly→ pushes…:atom-nightly-pr999; an unknown engine → usage, rc 2.release.ymlpreparewith the new default → matrix["sglang","vllm","atom","atom-nightly","kvd","server"]; overlay still gated on sglang + vllm.Dockerfile.atomis what feat(atom): optimize atom pd performance #209 was validated with (patches apply onnightly_202610131505, AITER prebuild,check_dcp_merge.py).pre-commiton the changed files passes;bash -n;git diff --check.Follow-up
The
v0.3.1tag and GitHub Release were withdrawn before any image was built (the release run was cancelled, nothing pushed, PyPI not published). After this merges,v0.3.1will be re-tagged on the newmainso the release includesatom-nightly-v0.3.1.🤖 Generated with Claude Code