Repository navigation
chore(tools): remove tools/kbmine - #1906
Conversation
kbmine is a standalone estimator that mines Recipe KB and Pulse evidence outside the Hyperloom workflow, and nothing in src/ imports it. Remove the directory added in #1778 together with its pytest testpaths and pythonpath entries in pyproject.toml. Co-authored-by: Cursor <cursoragent@cursor.com>
Code metrics gate: PASSEDJudged: the 16 files this change touches. Files it does not touch never fail it; anything found there is listed under Outside this change for information.
95 findings in files this change does not touchOutside this change (informational): 95
...and 70 more; the job log lists every row.
Thresholds and sources: |
|
/review |
Review of #1906 -- chore(tools): remove tools/kbmineWhat it does: Deletes Blocking issues: none.
Checked: tree-wide sweep for every surviving reference -- Config side effects: Description against the diff at head: the 15-file / 4453-line total re-summed from the per-file counts, both quoted config values matched against the head tree, Ran: no local test run -- this diff deletes tests and touches no Base: LGTM |
xiaofei-zheng
left a comment
There was a problem hiding this comment.
No blocking issues. Reviewed in detail in the comment above: tree-wide sweep for surviving references (0 hits at head; the only external references at the merge base were the two [tool.pytest.ini_options] entries this PR removes), path-level references checked separately across workflow paths: filters, REUSE, CODEOWNERS, pre-commit, dependabot, readthedocs and the docs toctrees, coverage denominator and code-metrics roots confirmed never to have included tools/, and every factual claim in the description re-derived against the head tree. CI green at head: 31 success, 0 failures.
Removes
tools/kbmine. kbmine is a standalone estimator that mines the Recipe KB and Pulse for evidence prior sessions produced. Its own README states that nothing insrc/imports it, and that the estimator was first proposed inside the optimizer as #1391, which was closed because mining fleet evidence is not part of the Hyperloom workflow. Keeping it here still puts a separately packaged tool (its ownpyproject.toml, CLI, TLS provisioning script and docs) under Hyperloom's CI, review and release. This PR deletes the directory added in #1778 and the two pytest settings that pointed at it.tools/kbmine/tests(test_kbmine_mine.py,test_kbmine_tls.py,conftest.py), which tested only the removed tool. Checked:git grep -i kbminefinds no remaining reference;pyproject.tomlparses withtomllib, and[tool.pytest.ini_options]now readstestpaths = ["src/**/tests", "scripts/tests"]andpythonpath = ["src", ".", "scripts"]. The full suite is left to CI.pyproject.tomlentries.src/,scripts/, the docs site or the workflows referenced it, andscripts/code_metrics_baseline.txthas no kbmine entry.python -m kbmine.cliandpip install -e tools/kbmineare no longer available from a Hyperloom checkout, and pytest no longer collectstools/kbmine/tests. The optimizer, its CLI and everything a session publishes are unchanged.hyperloomdistribution or its entry points. Anyone using the standalone tool from this repository needs to take it from elsewhere.