Repository navigation
Stop pinning README bytes in reviewed contract history - #132
Merged
Merged
Conversation
The reviewed-history records let the older migration tests prove that a task's current files reproduce their original bytes after reviewed edits. Only the config, workload and kernel-source records feed those tests. The 48 README records were checked by nothing but their own self-test, so every documentation edit to these tasks required regenerated records. Drop the README records and the README-only composition step, keep every contract record, and assert that only contract files remain pinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/reviewed_contract_history.pystores exact inverse records for reviewed task-contract edits. The older migration tests use them to restore a task file's original bytes, which proves that later PRs changed task contracts only through reviewed edits.Only the
config.yaml, workload and kernel-source records feed those tests. The 48 README records — 45 inTRITON_DEVICE_BOUNDARY_FILESand 3 inATTENTION_SAMPLING_COVERAGE_FILES— were checked only by their own self-test, which froze the README text. Every documentation edit to these tasks therefore required regenerated records; #127 listed this as a known limitation.Changes
historical_triton_device_boundary_file.No task file, harness, workload, tolerance or timing changes. No GPU validation is needed.
Validation
tasks/triton2triton/vllm/triton_bmm/README.md, the same 2,813 tests still pass. Before this change, the README pin self-test rejected that edit.