Phase 5: Reliability & Production Hardening#6
Merged
Conversation
Buffer pool: - Discard oversized vectors (>2x default size) on release instead of pooling them. Prevents a single large outlier image from permanently inflating the pool's memory footprint. Pipeline: - Add samples_skipped_ atomic counter incremented on each corrupted sample skip (both GPU and CPU decode paths) - Add skipped_samples() public accessor for monitoring data quality from Python bindings Tests: - Add oversized vector discard test verifying pool doesn't retain buffers grown beyond 2x threshold
The samples_skipped_ atomic counter is owned by UnifiedPipeline but was referenced directly inside TarWorker::run() which is a separate class. Fix by passing a pointer through the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
samples_skipped_atomic counter incremented on each corrupted sample skip (both GPU and CPU decode paths). Exposeskipped_samples()accessor for monitoring data quality from Python.Test plan