Phase 4: Transform Correctness#5
Merged
Merged
Conversation
Color jitter: - Fix contrast to use per-channel mean instead of global mean across all channels, matching torchvision's behavior. This was causing incorrect contrast adjustments that shift all channels toward a single average, producing color shifts during training. Bilinear interpolation: - Fix boundary clamping order: clamp x0/y0 before computing x1/y1 and fractional parts. The old code computed x1 from unclamped x0, which could read 1 pixel out of bounds at image edges with negative source coordinates. - Clamp dx/dy to [0,1] to prevent extrapolation artifacts. Tests: - Add per-channel contrast test verifying R/G/B means stay near their original values (not dragged toward a global mean) - Add bilinear boundary safety test with negative coords and beyond-bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan