[pull] trunk from WordPress:trunk - #1
Open
pull[bot] wants to merge 3314 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
force-pushed
the
trunk
branch
2 times, most recently
from
July 6, 2026 03:10
3af2d27 to
64ede28
Compare
…een. Add a parent selector to the misc actions section of the Edit Comment screen, so a comment can be moved to a different thread or made top-level without editing the database directly. The selector is only rendered when comment threading is enabled. It lists the post's approved and pending comments, capped at the 100 most recent, and omits comments that cannot become the parent. Props matt, mcsf, tyxla, westonruter, youknowriad. Fixes #65570. git-svn-id: https://develop.svn.wordpress.org/trunk@62673 602fd350-edb4-49c9-b593-d223f7449a82
REST GET and DELETE requests deliver every query string parameter as a string ("10", "true") and comma-separated values as a single string, so without coercion an ability receives raw strings where its input schema declares integers, booleans, or arrays.
This commit coerces the run input to the types declared by the ability's input schema before the ability executes. The coercion is registered as the `input` argument's `sanitize_callback`, so it runs once during `sanitize_params()` and both the permission and execution callbacks receive natively typed input from the same request object.
Props jorgefilipecosta, gziolo, mukesh27.
Fixes #65594.
git-svn-id: https://develop.svn.wordpress.org/trunk@62674 602fd350-edb4-49c9-b593-d223f7449a82
This removes redundant array entries that were silently overwritten by a later key with the same name. Follow-up to [943/tests], [53941], [59866]. Props Soean. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62675 602fd350-edb4-49c9-b593-d223f7449a82
Developed as subset of #12201 Props westonruter, gziolo. See #64898, #65476. git-svn-id: https://develop.svn.wordpress.org/trunk@62680 602fd350-edb4-49c9-b593-d223f7449a82
Add a dashboard widget that shows users past entries published on the same month and day from previous years. The widget is hidden if there are no history to show for the date. Props alshakero, eclev91, annezazu, westonruter, kellychoffman, simison, joen, retrofox, audrasjb, desrosj, peterwilsoncc, matt, sabernhardt, wildworks, jeherve, apermo, dmsnell, jonsurrell, jorbin, talldanwp, retrofox, joedolson. Fixes #65116. git-svn-id: https://develop.svn.wordpress.org/trunk@62681 602fd350-edb4-49c9-b593-d223f7449a82
Add PHPStan array shapes for the `$args` parameter of `wp_insert_term()`, `wp_update_term()`, and `wp_delete_term()`, along with narrowed return types. The types describe the contract these functions are intended to be called with, rather than what unguarded callers happen to pass today. Developed in #12465. Follow-up to r62680. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62682 602fd350-edb4-49c9-b593-d223f7449a82
All media types used the label `Caption` for the data stored in `$post->post_excerpt`. This label is only meaningful for image media types, and misrepresents the content for video and audio, where `caption` has a different specific meaning. Change the labels to use `Image Caption` for the image case, and `Short Description` for all other cases, so that the label represents the explicit usage where core uses the data, and represents the internal storage model for cases where core does not use the data. Props postphotos, bridgetwillard, kirasong, joemcgill, afercia, pento, karmatosed, desrosj, jamesbregenzer, abcd95, aperto, joedolson. Fixes #43178. git-svn-id: https://develop.svn.wordpress.org/trunk@62683 602fd350-edb4-49c9-b593-d223f7449a82
Introduce an `application_password` connector authentication method. Registering a connector with this method auto-generates and registers a setting named `connectors_{$type}_{$id}_application_password` that stores the username and application password together as an object through the Settings API.
Only the application password is masked in REST responses; non-secret connection metadata is exposed to the admin UI via the connector script module data. Credentials may also be supplied through constants or environment variables, and malformed external values are reported with `_doing_it_wrong()` and skipped so resolution falls through to the next source.
Props jorgefilipecosta, gziolo, jorbin.
See #64850.
git-svn-id: https://develop.svn.wordpress.org/trunk@62684 602fd350-edb4-49c9-b593-d223f7449a82
…st table Compact view. Posts and pages with no title previously displayed only "(no title)" in the posts list table, making untitled items hard to tell apart. When a post has no title, this appends up to 15 words of its trimmed excerpt after the title link in the Compact (list) view. The excerpt is only shown when the Excerpt view is not active, the post has no title, no password is required, and the current user can read the post. The checkbox and locked-post accessibility labels are updated to match the visible link text, and optional styling is added for the trimmed excerpt. Props sabernhardt, mcsf, tyxla, annezazu, ramonopoly, joen, wildworks, joedolson, jeffpaul, matt. Fixes #65022. git-svn-id: https://develop.svn.wordpress.org/trunk@62685 602fd350-edb4-49c9-b593-d223f7449a82
On Settings → General, live-previewing an unsaved site title change no longer removes the admin bar site icon: the icon element is preserved and re-prepended when the title text is updated. Additionally, adding, changing, or removing the site icon is now live-previewed in the admin bar, keeping the toolbar in sync with the `img.site-icon` element and the `has-site-icon` class before the form is saved. Developed in: #12474. Props fushar, tyxla. Fixes #65606. git-svn-id: https://develop.svn.wordpress.org/trunk@62686 602fd350-edb4-49c9-b593-d223f7449a82
The HTML specification was updated to include _processing instructions_ like `<?wp-processing-instruction ...data?>`. Implement processing instruction support in the HTML API. Developed in #12424. Props jonsurrell, dmsnell, westonruter. Fixes #65582. See #65581. git-svn-id: https://develop.svn.wordpress.org/trunk@62687 602fd350-edb4-49c9-b593-d223f7449a82
Provide clearer guidance for reassigning or deleting content when deleting users in both single and multisite instances. Content assignment is handled on a per-user basis, rather than forcing all content to be assigned to a single user. Add validation to enforce making a selection. Add fieldsets and legends to improve form structure and accessibility. Move inline JS to `common.js`. Improve backend logic to process per-user content handling. Exclude users being deleted from dropdown forms. Developed in #10502, #12467 Props stefan.velthuys, ocean90, hellofromTonya, akshat2802, hubersen, fakhriaz, ozgursar, sirlouen, realloc, audrasjb, joedolson, afercia, krokodok. Fixes #56914. git-svn-id: https://develop.svn.wordpress.org/trunk@62688 602fd350-edb4-49c9-b593-d223f7449a82
The HTML standard was updated to support customizable SELECT elements. Update HTML API parsing accordingly. Developed in #9298. Props jonsurrell, dmsnell. Fixes #63736. git-svn-id: https://develop.svn.wordpress.org/trunk@62689 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [14760], [17771]. Props arshidkv12. Fixes #65604. git-svn-id: https://develop.svn.wordpress.org/trunk@62690 602fd350-edb4-49c9-b593-d223f7449a82
Set height of scrollable container to exclude the modal footer so that the bottom of the scrollbar remains visible and accessible. Simplify styling by eliminating small viewport height adjustment. Change modal positioning in mobile viewports to ensure entire modal is visible with a masked margin. Developed in #11957 Props projektisle, alanjacobmathew, joedolson, sabernhardt. Fixes #65334. git-svn-id: https://develop.svn.wordpress.org/trunk@62691 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #12477. Follow-up to r38832, r62431. Props sabernhardt, baikaresandeep007, wildworks, gaurangsondagar. See #65112. Fixes #65119. git-svn-id: https://develop.svn.wordpress.org/trunk@62692 602fd350-edb4-49c9-b593-d223f7449a82
Developed in: #12343 Props iamchitti, paulkevan, wildworks. Fixes #65509. git-svn-id: https://develop.svn.wordpress.org/trunk@62693 602fd350-edb4-49c9-b593-d223f7449a82
Narrow the conditional `@phpstan-return` types of `get_post()`, `get_page()`, `get_page_by_path()`, `get_children()`, and `wp_get_recent_posts()` so that the `ARRAY_A` and `ARRAY_N` outputs are typed as `non-empty-array` instead of `array`. This is consistent with `WP_Post::to_array()`, which always returns at least the object's declared properties and so can never yield an empty array. Slight refactoring is done on `wp_get_recent_posts()` to support static analysis. Additionally, `wp_get_post_revision()` had no conditional return type at all, so its result was seen as `WP_Post|array|null` regardless of the requested `$output`. Describing it precisely resolves 30 pre-existing `Cannot access property $ID on array|WP_Post` errors in its callers. Furthermore, `trackback_url_list()` now bails when `get_post()` returns `null`. Previously it fell through to `$postdata['post_excerpt']`, emitting "Trying to access array offset on value of type null" warnings when called with an invalid post ID. Developed in #12485. Follow-up to r62648. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62694 602fd350-edb4-49c9-b593-d223f7449a82
This replaces `array_values( ... )[0]` and `array_slice( ..., 0, 1 )[0]` constructs with the `array_first()` function added in PHP 8.5 for improved readability. WordPress core includes a polyfill for `array_first()` on PHP < 8.5 as of WordPress 6.9, so the change works on every supported PHP version without raising the minimum requirement. Follow-up to [9685], [50995], [60672]. Props Soean, mukesh27. See #65598. git-svn-id: https://develop.svn.wordpress.org/trunk@62695 602fd350-edb4-49c9-b593-d223f7449a82
The word 'Toggle' poses complications in translations in numerous languages, having no direct translation. Replace user facing strings in the admin that currently use 'Toggle' with alternatives appropriate to their usage and actions. Developed in #11806 Props xibe, SergeyBiryukov, afercia, GaryJ, Presskopp, garrett-eclipse, NekoJonez, khokansardar, ramiy, joedolson. Fixes #34753. git-svn-id: https://develop.svn.wordpress.org/trunk@62696 602fd350-edb4-49c9-b593-d223f7449a82
Fix the alignment of the label, input field, and Submit button for getting your user favorites in the plugins screen. Modernizes layout to use flex layout and improves small viewports. Developed in #11806 Props bayejid00, deepakprajapati, shreyasikhar26, tusharaddweb, joedolson, sabernhardt. Fixes #65231. git-svn-id: https://develop.svn.wordpress.org/trunk@62697 602fd350-edb4-49c9-b593-d223f7449a82
Using the same image multiple times with a `figure` and `fig caption` would result in duplicate IDs, creating unclear relationships and breaking 3rd party expectations for anchor targets. Check id attributes and append a counter to ensure each attribute is unique, while retaining the current expectation of a counter-less ID attribute for the first instance. Update tests to verify. Developed in #11940 Props steelwagstaff, westonruter, jamesbregenzer, joedolson, mukesh27. Fixes #65315. git-svn-id: https://develop.svn.wordpress.org/trunk@62698 602fd350-edb4-49c9-b593-d223f7449a82
Some `@param` tags did not match their method signatures. This corrects the names and types, and removes the tags for parameters that no longer exist. Two `@dataProvider` annotations also had no effect. The one on `test_prepare_item()` is removed, and `test_get_items_search_type_post_subtype_invalid()` now accepts `$method` and passes it to the request. Developed in: #12208 Props Soean, mukesh27, wildworks. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62957 602fd350-edb4-49c9-b593-d223f7449a82
Follow up to [62838]. The changes to move column headers to the post title column did not account for the responsive tables in mobile viewports. Modernizes layout of responsive tables to use `flex` layout. Visual change expected, aligning the toggled hidden cells under the full row, including the checkbox, rather than only under the title column. Update several other styles to fix alignment changes caused by the `th` adjustment. Developed in #12737 Props afragen, khokansardar, mirmpro, habiburdev, sabernhardt, afercia, shailu25, joedolson. Fixes #65743. git-svn-id: https://develop.svn.wordpress.org/trunk@62958 602fd350-edb4-49c9-b593-d223f7449a82
…ulk editing. Updates Media Library grid toolbar styling to prevent content shifting and normalizes button appearance when switching modes (e.g., Bulk Select mode) by stabilizing toolbar height and removing unintended button sizing. Also, adjusts the buttons styling so that 'button-links' for destructive actions use the intended red color and prevents them from being styled as standard buttons. Developed in #12714 Props afercia, joedolson, shailu25, khokansardar, ozgursar. Fixes #65732. git-svn-id: https://develop.svn.wordpress.org/trunk@62959 602fd350-edb4-49c9-b593-d223f7449a82
…x()`. Trac ticket: Core-64567. Previously, `get_attribute_names_with_prefix()` was overlooking enqueued attribute and class name updates which occurred before `get_updated_html()` had been called. This resulted in reporting stale data which might overlook attributes which were added, and might report attributes which were removed. In this patch, the method now examines the enqueued updates to determine if any of them introduce or remove attributes. It also examines enqueued class updates to ensure that if the `class` attribute would be added or removed because of them that it will also be properly reported. Developed in: #12757 Discussed in: https://core.trac.wordpress.org/ticket/64567 Follow-up to [55203]. Props anupkankale, irozum, itzmekhokan, luisherranz, motylanogha, phpbits, sachinrajcp123, whaze. See #64567. git-svn-id: https://develop.svn.wordpress.org/trunk@62960 602fd350-edb4-49c9-b593-d223f7449a82
Items per page, items per feed, and comment link moderation settings used inappropriate structures. For posts per page and items per feed, the label was missing context, provided in an orphaned text string; for the comment link moderation settings, the label used a sentence structure that created mis-ordered labeling for screen reader users. The labels also use numeric interpolations that should require handling plural and singular translations separately. Alter structure to use appropriate combinations of `label` and `aria-describedy` structures, making the labeling more consistent and accessible. Restructures text to remove the need for alternate translations based on number. Developed in #12777 Props pavelevap, garyj, sergeybiryukov, shailu25, wildworks, johnbillion, chriscct7, afercia, garrett-eclipse, joedolson. Fixes #29299. git-svn-id: https://develop.svn.wordpress.org/trunk@62961 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #12784 Props sukhendu2002, mukesh27, iqbal1hossain, afercia. Fixes #65767. git-svn-id: https://develop.svn.wordpress.org/trunk@62962 602fd350-edb4-49c9-b593-d223f7449a82
Under jQuery 4.0, disabling a media button or the image cropper's action button triggered a jQuery Migrate warning about the boolean `disabled` attribute. These buttons now toggle the `disabled` property instead, which removes the warning and keeps the behavior unchanged. Developed in: #10661 Props audrasjb, azaozz, hbhalodia, neo2k23, wildworks. See #64425. git-svn-id: https://develop.svn.wordpress.org/trunk@62963 602fd350-edb4-49c9-b593-d223f7449a82
…Processor`. The `str_contains()` function was introduced in PHP 8.0 and a polyfill is available in WordPress Core, making the intent of the check clearer than comparing the result of `strpos()` against false. Follow-up to [62687]. Props Soean, mukesh27, westonruter. See #64897. git-svn-id: https://develop.svn.wordpress.org/trunk@62964 602fd350-edb4-49c9-b593-d223f7449a82
Many constants were defined as empty strings, including ones that never hold an empty value in a real install. Realistic values are provided for those, matching what wp-settings.php and default-constants.php would produce, so that functions building on them can be given narrower types without the placeholder itself violating them. Constants core itself defines as empty, such as WP_DEVELOPMENT_MODE and COOKIE_DOMAIN, are left as they were. Developed as subset of #11851. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62965 602fd350-edb4-49c9-b593-d223f7449a82
Per the inline documentation standards, a docblock's summary belongs on its own line separated from the description, and the description should not open with "It". This is applied to `register_block_script_module_id()`, `register_block_script_handle()`, and `register_block_style_handle()`, together with some missing articles in the same descriptions. Two of those descriptions no longer matched the code. `register_block_script_handle()` said the script is registered under an automatically generated handle, but since 6.5.0 the handle is taken from the asset file whenever one provides it, and generation is only the fallback. `register_block_style_handle()` said it returns the unprocessed style handle otherwise, which does not hold for the first style of a core block: that one is registered from the block's own stylesheet when separate core block assets are loaded, and skipped entirely when they are not. The same functions gain `@phpstan-` annotations describing the shape of the `$metadata` they accept and the narrower strings they return. The shapes follow the `block.json` schema, which constrains only `name`, so the remaining fields stay plain strings; `file` is nullable and `name` optional because `register_block_type_from_metadata()` can reach all three functions with neither present. Developed in #11851. Follow-up to r48141, r55447, r57559, r57565. Props deepakrohilla, westonruter, sabernhardt, wildworks, audrasjb. See #64898. Fixes #65259. git-svn-id: https://develop.svn.wordpress.org/trunk@62966 602fd350-edb4-49c9-b593-d223f7449a82
In several contexts (Add New User, Install, and Setup/Config), the show/hide password icon was misaligned in varying amounts in different viewports. Add the classes `wp-hide-pw` and `user-new-password-toggle` to the button container to re-use existing CSS consistently. Developed in #12472 Props sanayasir, iamchitti, softglaze, shailu25, soyebsalar01, noruzzaman, ugyensupport, wildworks, ankitpatel1578, praful2111, joedolson, sabernhardt. Fixes #65605. git-svn-id: https://develop.svn.wordpress.org/trunk@62967 602fd350-edb4-49c9-b593-d223f7449a82
Match the behavior of posts in list tables by showing a short excerpt in the On This Day widget when the post does not have a saved title. Developed in #12581 Props alshakero, softglaze, iamraju, mirmpro, shailu25, bph, nazmulasif, wildworks, annezazu, mukesh27, peterwilsoncc, joedolson. Fixes #65658. git-svn-id: https://develop.svn.wordpress.org/trunk@62968 602fd350-edb4-49c9-b593-d223f7449a82
…ith booleans. Using the dedicated boolean assertions clarifies intent and produces more descriptive failure messages. Follow-up to [51453]. Props Soean, mukesh27. See #64894. git-svn-id: https://develop.svn.wordpress.org/trunk@62969 602fd350-edb4-49c9-b593-d223f7449a82
Props oandregal, ntsekouras. See #65577. git-svn-id: https://develop.svn.wordpress.org/trunk@62970 602fd350-edb4-49c9-b593-d223f7449a82
Removes a duplicate `@param` tag carrying an outdated type and restores the description of the returned value. Developed in: #12791 Follow-up to [61603]. Props bejignesh, mukesh27, wildworks. See #64896. git-svn-id: https://develop.svn.wordpress.org/trunk@62971 602fd350-edb4-49c9-b593-d223f7449a82
When installing a theme from the Details & Preview overlay, the animated icon shown in the Install button was taller than the button itself, so the button grew and its label shifted while the install was in progress. Matching the icon height to the button height keeps the button at a stable size and the icon aligned with the label throughout the updating and updated states. Developed in: #12799 Follow-up to [62516]. Props eishanoor, kosvrouvas, mosescursor, r1k0, shailu25, ugyensupport, vedantere, wildworks. Fixes #65601. git-svn-id: https://develop.svn.wordpress.org/trunk@62972 602fd350-edb4-49c9-b593-d223f7449a82
The `search` and `page` parameters source of truth is the URL, and cannot be configured via the filters. Props oandregal, ntsekouras, jorgefilipecosta. Fixes #65577. git-svn-id: https://develop.svn.wordpress.org/trunk@62973 602fd350-edb4-49c9-b593-d223f7449a82
[62891] introduced the ability to override the runner used for a GitHub Actions job using a repository or organization variable. While initially named `PHPUNIT_RUNNER`, overriding the runner for a specific job could be useful in more situations. This renames the variable chacked to `RUNNER_GROUP`. Fixes #65749. git-svn-id: https://develop.svn.wordpress.org/trunk@62974 602fd350-edb4-49c9-b593-d223f7449a82
This is a maintenance and minor security release. References: * [https://github.com/PHPMailer/PHPMailer/releases/tag/v7.1.1 PHPMailer 7.1.1 release notes] * [https://github.com/PHPMailer/PHPMailer/releases/tag/v7.1.0 PHPMailer 7.1.0 release notes] * [PHPMailer/PHPMailer@v7.0.2...v7.1.1 Full list of changes in PHPMailer 7.1.1] Follow-up to [54937], [55557], [56484], [57137], [59246], [59481], [60623], [60813], [60888], [61249], [61468]. Props hareesh-pillai, Synchro, jrf. Fixes #65790. git-svn-id: https://develop.svn.wordpress.org/trunk@62975 602fd350-edb4-49c9-b593-d223f7449a82
The list and grid filter panels had different padding following [61757]. This is an undesirable difference, and should be equalized. Apply scoped padding to match the two filter bars. Developed in #12664 Props afercia, softglaze, khokansardar, joedolson. Fixes #65697. git-svn-id: https://develop.svn.wordpress.org/trunk@62976 602fd350-edb4-49c9-b593-d223f7449a82
While the intention was to only render the On This Day widget when it returned results, this proved to create a variety of implementation complications and some significant points of confusion for users. Remove the conditional rendering of the On This Day widget. When active without posts, display a message inviting the user to publish a new post. Developed in #12575 Props iamchitti, mirmpro, shailu25, ugyensupport, iamraju, nazmulasif, wildworks, joedolson, mukesh27, annezazu, paaljoachim, joen. Fixes #65647. git-svn-id: https://develop.svn.wordpress.org/trunk@62977 602fd350-edb4-49c9-b593-d223f7449a82
The stored `filesize` attachment metadata was read without validation in `wp_prepare_attachment_for_js()` and `attachment_submitbox_metadata()`. Attachment metadata is untyped, and the `filesize` key is commonly written by offloading plugins from a remote storage API response, so it can arrive as a numeric string, or be empty, non-numeric, or negative when the remote lookup fails. A numeric string was passed through verbatim, making `filesizeInBytes` a string in the media modal while the `wp_filesize()` branch of the very same conditional yielded an `int`; a non-numeric value such as `'unknown'` was truthy and suppressed the fallback entirely, so `size_format()` returned `false` and the file size rendered empty even when the real file was readable. Both call sites now only trust the stored value when it is numeric and casts to an integer greater than zero, and otherwise recompute the size with `wp_filesize()`. The fallback condition also replaces `file_exists()` with `is_readable()` guarded on a non-empty string, since `get_attached_file()` can be filtered to return a non-string. PHPUnit coverage is added for both functions. Developed in #12632. Follow-up to r34258, r52837, r62813, r62815. Props mukesh27, westonruter. See #65670. Fixes #65686. git-svn-id: https://develop.svn.wordpress.org/trunk@62978 602fd350-edb4-49c9-b593-d223f7449a82
The On This Day dashboard widget has been bumped from the WordPress 7.1 release to the 7.2 release pending design and behavioural improvements. This reverts r62977, r62968, r62852, r62681. Props annezazu, matt, peterwilsoncc. Fixes #65801. git-svn-id: https://develop.svn.wordpress.org/trunk@63001 602fd350-edb4-49c9-b593-d223f7449a82
Attachment metadata is untyped, and the `sizes` key is not guaranteed to be present or to hold an array. Sub-size generation can leave it out entirely, and a plugin filtering `wp_get_attachment_metadata` can replace it with anything. `wp_save_image()` validated only that the metadata itself was an array before passing `$meta['sizes']` to `array_merge()`, so an absent or scalar value raised a `TypeError` and the image editor returned an HTTP 500 mid-save. `wp_restore_image()` had the same gap at `$meta['sizes'][ $default_size ] = $data`, where a string raises "Cannot use a scalar value as an array" and `false` is deprecated as of PHP 8.1 and an error as of PHP 9. `wp_get_attachment_metadata()` now returns `false` whenever the metadata is not an array, on the `$unfiltered` path as well as after the filter, matching the documented `array|false` return. A `sizes` key holding a non-array is replaced with an empty array, so every caller can rely on the key being an array whenever it is present. The key is not invented when it is absent: audio, video and document attachments legitimately store metadata without it, and callers such as `wp-admin/post.php` read the metadata unfiltered in order to modify it and write it back, so normalizing there would persist into the database. The image editor entry points fill in the missing key themselves, and `wp_prepare_attachment_for_js()` now checks the dimensions of the `full` entry alongside its filename before reading them, removing the "Undefined array key" warnings raised for a `sizes` array that carries no usable `full` size. PHPUnit coverage is added for all three functions. Developed in #12744. Follow-up to r11965, r23873, r38949, r49084, r62978. Props josephscott, westonruter, mukesh27, irozum, ugyensupport, nazmulasif. See #65686, #64898. Fixes #65748. git-svn-id: https://develop.svn.wordpress.org/trunk@63002 602fd350-edb4-49c9-b593-d223f7449a82
This changes `RUNNER_GROUP` to `RUNNERS_NAME` to avoid confusion with the `runs-on.group` setting, which is configured in a completely different way. Props lancewillet. See #65749. git-svn-id: https://develop.svn.wordpress.org/trunk@63003 602fd350-edb4-49c9-b593-d223f7449a82
The `suggest` section had accumulated only four extensions, added ad hoc as individual changes happened to need them. It now lists every extension that the Hosting handbook's server environment page [https://make.wordpress.org/hosting/handbook/server-environment/#required-extensions identifies] as required, highly recommended, or suggested. This lets development environments be provisioned to match what core actually expects, and gives IDEs an accurate picture of which functions are available. The `require` section is deliberately left unchanged: the `mysqli` extension stays a suggestion rather than a requirement since a `db.php` drop-in can supply the database layer without it. Developed in #12384. Follow-up to r56687, r62529, r62637. Fixes #65571. git-svn-id: https://develop.svn.wordpress.org/trunk@63004 602fd350-edb4-49c9-b593-d223f7449a82
…rtNotIXRError`. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@63005 602fd350-edb4-49c9-b593-d223f7449a82
Passing anything other than a struct as the fourth argument caused a fatal error, and because the struct was read before the login was attempted, an unauthenticated request was enough to trigger it. Read and validate the struct only once the request is authenticated and the `upload_files` capability is confirmed, as every other method on the server does, and reject a call with too few arguments using `minimum_args()`. The `name`, `type` and `bits` members must all be strings: a struct sent for `bits` reached `fwrite()` by way of `wp_upload_bits()` and threw a `TypeError`, while one sent for `type` survived `sanitize_mime_type()` to reach the database as the attachment's post MIME type. A `name` left empty by `sanitize_file_name()` is now reported as a malformed request too, rather than as the server failure `wp_upload_bits()` produced for it. The fourth argument is expanded into a nested hash in the documentation, covering the previously undocumented `post_id` member. Tests cover each rejected shape, the optional members that remain tolerated when absent, and the ordering of the login and capability checks ahead of the validation. Developed in #12482. Follow-up to r32579, r53881. Props josephscott, westonruter, mukesh27. See #65600. Fixes #65611. git-svn-id: https://develop.svn.wordpress.org/trunk@63006 602fd350-edb4-49c9-b593-d223f7449a82
The media editor modal rendered without its intended styles, because the stylesheet it relies on was never registered in core. Registering the handle makes the modal display as intended. Developed in #12813 Props afercia, andrewserong, gulamdastgir04, mdridipu, ramonopoly, softglaze, wildworks. Fixes #65794. git-svn-id: https://develop.svn.wordpress.org/trunk@63007 602fd350-edb4-49c9-b593-d223f7449a82
…otice. Follow-up to [https://mu.trac.wordpress.org/changeset/1968 mu:1968], [https://mu.trac.wordpress.org/changeset/2005 mu:2005], [13590]. Props bor0, realloc. Fixes #65792. git-svn-id: https://develop.svn.wordpress.org/trunk@63008 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )