Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the <|endoftext|> token to the TextVQA dataset's special tokens and ensures the file ends with a newline. Feedback was provided to improve the efficiency of token removal using regular expressions and to address several bugs in the scoring logic, such as in-place modifications and incorrect accuracy calculations.
| '!', | ||
| ] | ||
| self.special_tokens = ['☞', '☟', '☜', '<unk>', '<|im_end|>'] | ||
| self.special_tokens = ['☞', '☟', '☜', '<unk>', '<|im_end|>', '<|endoftext|>'] |
There was a problem hiding this comment.
The addition of <|endoftext|> is appropriate for cleaning model outputs. However, as this list grows, the current implementation of remove_special_characters (which uses a loop of str.replace calls) becomes increasingly inefficient. Consider using a single regular expression for token removal.\n\nAdditionally, please be aware of several existing issues in the evaluation logic within this file that should be addressed to ensure benchmark accuracy:\n1. In-place modification: The score method modifies the references dictionaries in place (line 323), which can lead to inconsistent results across multiple evaluation runs or replicas.\n2. Incorrect VQA accuracy logic: The logic for calculating other_gt_ans (line 326) using item != gt_ans incorrectly removes all identical ground truth answers. In VQA evaluation, only the current annotator's answer should be excluded, not all identical answers.\n3. Conditional normalization: Ground truth answers are only normalized if there is more than one unique answer in the set (line 321), which can lead to false negatives when comparing against the always-normalized predictions.
Thanks for your contribution; we appreciate it a lot. The following instructions will make your pull request healthier and help you get feedback more easily. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
感谢您的贡献,我们非常重视。以下说明将使您的拉取请求更健康,更易于获得反馈。如果您不理解某些项目,请不要担心,只需提交拉取请求并从维护人员那里寻求帮助即可。
PR Type / PR类型
Related Issue | 关联 Issue
Fixes #(issue ID / issue 编号) / Relates to #(issue ID / issue 编号)
🔍 Motivation / 变更动机
增加字符后处理规则
📝 Modification / 修改内容
Please briefly describe what modification is made in this PR.
请简要描述此拉取请求中进行的修改。
增加了字符后处理规则
📐 Associated Test Results / 关联测试结果
Please provide links to the related test results, such as CI pipelines, test reports, etc.
请提供相关测试结果的链接,例如 CI 管道、测试报告等。
glm4v 测试精度0.781
Does the modification introduce changes that break the backward compatibility of the downstream repositories? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
是否引入了会破坏下游存储库向后兼容性的更改?如果是,请描述它如何破坏兼容性,以及下游项目应该如何修改其代码以保持与此 PR 的兼容性。
If the modification introduces performance degradation, please describe the impact of the performance degradation and the expected performance improvement.
如果引入了性能下降,请描述性能下降的影响和预期的性能改进。
🌟 Use cases (Optional) / 使用案例(可选)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
如果此拉取请求引入了新功能,最好在此处列出一些用例并更新文档。
✅ Checklist / 检查列表
Before PR:
After PR:
👥 Collaboration Info / 协作信息
🌟 Useful CI Command / 实用的CI命令
/gemini review/gemini summary/gemini help/readthedocs build