Repository navigation
gui - #3
Merged
Merged
gui#3
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces the initial GUI040 implementation of AIMORAService: an authenticated local IPC service (framed control/binary protocol), bounded artifact window reads, and supervised out-of-process worker lifecycle, alongside deterministic schema-based C++ binding generation and expanded tests/documentation.
Changes:
- Add core Julia service implementation (types, framing, security/path confinement, server dispatch, worker supervision, CLI).
- Add protocol schema + deterministic C++ binding generator and committed generated C++ outputs.
- Add GUI040-focused test suite (framing/auth/path confinement/integration + worker supervision) and expand package docs/contributing guidance.
Reviewed changes
Copilot reviewed 18 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| AIMORASymbols/README.md | Updates symbols ownership/scope statement and licensing/provenance wording. |
| AIMORAService/src/AIMORAService.jl | Wires up the new service modules and exports the public surface. |
| AIMORAService/src/types.jl | Defines protocol constants, limits, and core public types/errors. |
| AIMORAService/src/framing.jl | Implements AMR1 frame encoding/decoding and control/binary payload handling. |
| AIMORAService/src/security.jl | Adds constant-time compare, path confinement, hashing, bounded file/window reads. |
| AIMORAService/src/workers.jl | Adds supervised worker launch/authentication, bounded shutdown, recovery logic. |
| AIMORAService/src/server.jl | Implements request validation, dispatch, resource tracking, and IPC serve loop. |
| AIMORAService/src/cli.jl | Adds CLI parsing, token-file authentication, and service startup. |
| AIMORAService/src/generator.jl | Implements schema parsing and deterministic C++ bindings generation. |
| AIMORAService/schema/service_protocol.json | Adds the canonical JSON protocol schema for GUI040. |
| AIMORAService/tools/generate_cpp_bindings.jl | Adds a CLI tool wrapper to generate C++ bindings from the schema. |
| AIMORAService/generated/cpp/include/.../service_protocol.hpp | Adds committed generated C++ header bindings. |
| AIMORAService/generated/cpp/src/service_protocol.cpp | Adds committed generated C++ source bindings. |
| AIMORAService/bin/aimora-service.jl | Adds service entrypoint script. |
| AIMORAService/bin/aimora-worker-probe.jl | Adds authenticated worker readiness publishing probe. |
| AIMORAService/test/runtests.jl | Switches test runner to GUI040 phases and includes new suites. |
| AIMORAService/test/runtests_gui040_base.jl | Adds GUI040 framing/auth/path confinement/integration/generator tests. |
| AIMORAService/test/worker_supervision.jl | Adds worker supervision + recovery/exhaustion tests. |
| AIMORAService/README.md | Substantially expands documentation for GUI040 design, usage, and limits. |
| AIMORAService/CONTRIBUTING.md | Adds required checks and protocol rules/testing expectations. |
| AIMORAService/Project.toml | Adds deps/compat and retains proper test extras/targets. |
| .github/workflows/ci.yml | Adds a job timeout to the CI workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+54
to
+61
| function _read_session_token(token_file::AbstractString) | ||
| isfile(token_file) || | ||
| throw(ServiceError("AUTHENTICATION_FAILED", "The session token file is unavailable.")) | ||
| if !Sys.iswindows() | ||
| mode = stat(token_file).mode | ||
| iszero(mode & 0o077) || | ||
| throw(ServiceError("AUTHENTICATION_FAILED", "The session token file is not private.")) | ||
| end |
Comment on lines
+216
to
+222
| current_size = bounded_file_size( | ||
| record.canonical_path, | ||
| state.configuration.limits.max_artifact_bytes, | ||
| ) | ||
| current_digest = sha256_file(record.canonical_path) | ||
| current_size == record.size_bytes && current_digest == record.sha256 || | ||
| throw(ServiceError("RESOURCE_NOT_FOUND", "The artifact reference is stale.")) |
Comment on lines
+7
to
+17
| const CAPABILITIES = String[ | ||
| "service.handshake", | ||
| "service.capabilities", | ||
| "service.ping", | ||
| "service.shutdown", | ||
| "project.reference", | ||
| "artifact.reference", | ||
| "result.binary-window", | ||
| "request.cancel", | ||
| "worker.lifecycle", | ||
| ] |
Comment on lines
+1
to
+2
| # SPDX-License-Identifier: PolyForm-Noncommercial-1.0.0 | ||
| using Test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.