Some minor touchup to preconditions and fix for minus.#104
Draft
haz wants to merge 4 commits intoAI-Planning:mainfrom
Draft
Some minor touchup to preconditions and fix for minus.#104haz wants to merge 4 commits intoAI-Planning:mainfrom
haz wants to merge 4 commits intoAI-Planning:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 88.35% 88.76% +0.41%
==========================================
Files 25 25
Lines 1794 1798 +4
Branches 333 335 +2
==========================================
+ Hits 1585 1596 +11
+ Misses 149 144 -5
+ Partials 60 58 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
Tests all run green, but marking this as WIP until we resolve the discussion over in #100 |
Contributor
Author
|
I do plan on getting back to this at some point... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Forgo negating an expression for the ability to subtract two expressions.
Fixes
Fixes #100, but also breaks the use of
-as something that negates.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.Further comments
More discussion over in #100