Repository navigation
[PR 1/5] A few pyink lint fixes from previous PR - #494
Closed
jitendra-jalwaniya wants to merge 1 commit into
Closed
jitendra-jalwaniya wants to merge 1 commit into
jitendra-jalwaniya wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies and formats several multi-line expressions into single-line statements across multiple files, including aot_cache.py, wan_pipeline.py, and their corresponding tests. However, the reviewer identified a potential bug in the refactored attention_config retrieval logic in both aot_cache.py and wan_pipeline.py. Specifically, using the 'or' operator can cause a falsy fallback if attention_config is an empty dictionary, resulting in an incorrect None value. The reviewer recommends replacing these expressions with direct conditional checks to ensure robustness.
jitendra-jalwaniya
changed the title
jitendra-jalwaniya
changed the title
jitendra-jalwaniya
requested review from
Perseus14
and removed request for
entrpn
September 29, 2026 07:54
Collaborator
|
Duplicate of #493 |
Collaborator
Author
Got it. Please review the other PRs. I'll discard this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few lint issues introduced in PR #480, this PR fixes them.