Skip to content

fix: update speedup calculations in summarize_results function for evaluation #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shangkunwang01 merged 1 commit into from
May 29, 2026
+2 −2
Merged

fix: update speedup calculations in summarize_results function for evaluation #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MaxKernel/evaluation/evaluation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,12 @@ def summarize_results(
max_speedup = max(speedups_cliped) if speedups_cliped else 1

arithmetic_mean_speedup = (
sum(speedups_cliped) / len(speedups_cliped) if speedups_cliped else 1
sum(speedups_cliped) / total_attempted if speedups_cliped else 1
)

# Geometric mean is more robust for averaging ratios like speedup.
geo_mean_speedup = (
math.exp(sum(math.log(s) for s in speedups_cliped) / len(speedups_cliped))
math.exp(sum(math.log(s) for s in speedups_cliped) / total_attempted)
if speedups_cliped
else 1
)
Expand Down