Skip to content

feat: add the adapted dataset from JaxBench#43

Merged
shangkunwang01 merged 1 commit into
mainfrom
shangkun-upload-jaxbench-adapted-dataset
May 29, 2026
Merged

feat: add the adapted dataset from JaxBench#43
shangkunwang01 merged 1 commit into
mainfrom
shangkun-upload-jaxbench-adapted-dataset

Conversation

@shangkunwang01
Copy link
Copy Markdown
Collaborator

No description provided.

@shangkunwang01 shangkunwang01 requested a review from NinaCai May 27, 2026 19:51
@shangkunwang01 shangkunwang01 force-pushed the shangkun-upload-jaxbench-adapted-dataset branch 2 times, most recently from 70dd48a to 3eddb9d Compare May 27, 2026 22:18
@shangkunwang01 shangkunwang01 force-pushed the shangkun-upload-jaxbench-adapted-dataset branch from 3eddb9d to 08d603c Compare May 27, 2026 22:43
Copy link
Copy Markdown
Collaborator

@NinaCai NinaCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There are some ops with optimized code e.g. MLA, right? They are not included in this PR?
  2. If you are able to get kernel_task.yaml file by using adapt script, would it make more sense to let the user run the script to generate the adapted benchmark? It is hard to keep track of original JaxBench and adapted JaxBench imo.

@shangkunwang01
Copy link
Copy Markdown
Collaborator Author

  1. There are some ops with optimized code e.g. MLA, right? They are not included in this PR?
  2. If you are able to get kernel_task.yaml file by using adapt script, would it make more sense to let the user run the script to generate the adapted benchmark? It is hard to keep track of original JaxBench and adapted JaxBench imo.
  1. Optimized code is not adapted yet. I will adapt it recently.
  2. The uploaded adapted code is verified by me and is consistent with current JaxBench. Adaptation by LLM is risky so I would suggest avoiding adapting the reference code and yaml file as much as possible. This adapted dataset should be the source of truth for our benchmark and any changes in JaxBench should be reflected in the adapted dataset and will be easy to do as we will only need to change single files manually.

@NinaCai
Copy link
Copy Markdown
Collaborator

NinaCai commented May 29, 2026

  1. There are some ops with optimized code e.g. MLA, right? They are not included in this PR?
  2. If you are able to get kernel_task.yaml file by using adapt script, would it make more sense to let the user run the script to generate the adapted benchmark? It is hard to keep track of original JaxBench and adapted JaxBench imo.
  1. Optimized code is not adapted yet. I will adapt it recently.
  2. The uploaded adapted code is verified by me and is consistent with current JaxBench. Adaptation by LLM is risky so I would suggest avoiding adapting the reference code and yaml file as much as possible. This adapted dataset should be the source of truth for our benchmark and any changes in JaxBench should be reflected in the adapted dataset and will be easy to do as we will only need to change single files manually.

I think this folder and JaxBench folder are somewhat duplicated and potentially inconsistent. Let's discuss how to handle the adapted JaxBench next week. For now, let's use this adapted folder.

@shangkunwang01 shangkunwang01 merged commit 2286d23 into main May 29, 2026
6 checks passed
@shangkunwang01
Copy link
Copy Markdown
Collaborator Author

  1. There are some ops with optimized code e.g. MLA, right? They are not included in this PR?
  2. If you are able to get kernel_task.yaml file by using adapt script, would it make more sense to let the user run the script to generate the adapted benchmark? It is hard to keep track of original JaxBench and adapted JaxBench imo.
  1. Optimized code is not adapted yet. I will adapt it recently.
  2. The uploaded adapted code is verified by me and is consistent with current JaxBench. Adaptation by LLM is risky so I would suggest avoiding adapting the reference code and yaml file as much as possible. This adapted dataset should be the source of truth for our benchmark and any changes in JaxBench should be reflected in the adapted dataset and will be easy to do as we will only need to change single files manually.

I think this folder and JaxBench folder are somewhat duplicated and potentially inconsistent. Let's discuss how to handle the adapted JaxBench next week. For now, let's use this adapted folder.

The JaxBench folder may be removed in the future. It will has its own repo according to Steven. The main reason I want to have this folder in github is for us to easily run benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants