Add xprof for autotune#40
Merged
Merged
Conversation
| timeout: Optional[int] = 30 | ||
| timeout: Optional[int] = 300 | ||
| profile: bool = True | ||
| kernel_name_pattern: Optional[str] = None |
Collaborator
There was a problem hiding this comment.
I don't see this is used in the autotune_tool so we can remove it and code related to it. The current implementation will always be none.
| search_space: dict[str, list] | ||
| timeout: Optional[int] = 30 | ||
| timeout: Optional[int] = 300 | ||
| profile: bool = True |
Collaborator
There was a problem hiding this comment.
How can people turn off profile? When autotune_tool send the request, it does not specify the profile arg and as a result it is always True. Since you always want profile, let's remove this field and always do profiling.
Collaborator
Author
There was a problem hiding this comment.
I thought auto-agent would not use profiling? I am ok with always using profiling.
Collaborator
There was a problem hiding this comment.
Yes. In that case we can keep code clean and remove this field and related code.
shangkunwang01
requested changes
May 27, 2026
shangkunwang01
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jit_computationorjitted_computationin the profile, otherwise, use the longest op in the profile.