Skip to content

add new methods and update testing for accuracy#14

Closed
jc-macdonald wants to merge 3 commits intoreduce_introspectionfrom
add_methods
Closed

add new methods and update testing for accuracy#14
jc-macdonald wants to merge 3 commits intoreduce_introspectionfrom
add_methods

Conversation

@jc-macdonald
Copy link
Copy Markdown
Collaborator

This pull request expands the Operator-Partitioned Engine (OP Engine) to support new stiff ODE solvers, enhances test coverage for these methods, and improves documentation and code quality. The main changes include adding fully implicit and Rosenbrock methods, updating the test suite to validate their accuracy and requirements, and clarifying the public API in the documentation.

Solver and API enhancements:

  • Added support for stiff ODE methods (implicit-euler, trapezoidal, bdf2, ros2) to CoreSolver, including optional Jacobian support, and updated the README to reflect these new capabilities. [1] [2]

Testing improvements:

  • Expanded the MethodName literal and ScalarRunCase dataclass to handle new methods and Jacobians, and added comprehensive accuracy and convergence tests for the new implicit solvers. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Added new tests to ensure that implicit methods require a Jacobian and that BDF2 enforces a uniform time grid.

Code quality and linting:

  • Updated pyproject.toml to ignore the PLR0914 linting rule in test files, reducing noise from parameter count warnings in pytest functions.

Minor test maintenance:

  • Removed unnecessary noqa: PLR0914 comments from test functions after updating linting configuration. [1] [2]

@jc-macdonald jc-macdonald marked this pull request as draft February 13, 2026 17:25
@jc-macdonald jc-macdonald self-assigned this Feb 13, 2026
@jc-macdonald jc-macdonald added the enhancement New feature or request label Feb 13, 2026
Copilot AI added a commit that referenced this pull request Mar 19, 2026
Co-authored-by: MacdonaldJoshuaCaleb <72512262+MacdonaldJoshuaCaleb@users.noreply.github.com>
@jc-macdonald
Copy link
Copy Markdown
Collaborator Author

supersceded by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant