perf: gate QueueSheet playing waveform animation on playback state - #1050
Merged
Merged
Conversation
Gated the PlayingWaveform animation in QueueSheet and QueueTrackRow on the playback state (`isPlaying = uiState.isPlaying`). Previously, when playback was paused, the queue sheet's currently playing track item's waveform bars would continue animating infinitely, consuming unnecessary frame budgets and CPU cycles. - Pass `isPlaying = uiState.isPlaying` from `FullMusicPlayerContent` to `QueueSheet` - Forward `isPlaying` to `QueueTrackRow` - Pass `animate = isPlaying` to `PlayingWaveform` in `QueueTrackRow`
github-actions
Bot
added
player
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gated the PlayingWaveform animation in QueueSheet and QueueTrackRow on the playback state (
isPlaying = uiState.isPlaying). Previously, when playback was paused, the queue sheet's currently playing track item's waveform bars would continue animating infinitely, consuming unnecessary frame budgets and CPU cycles.isPlaying = uiState.isPlayingfromFullMusicPlayerContenttoQueueSheetisPlayingtoQueueTrackRowanimate = isPlayingtoPlayingWaveforminQueueTrackRowChange type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTestRisk and compatibility