fix: explicitly dispatch docs deployment from create-tag.yml - #99
Merged
Merged
Conversation
GitHub blocks events triggered by GITHUB_TOKEN from starting other workflows (anti-recursion protection), so the release tag pushed by create-tag.yml never actually triggered docs.yml's tag-push trigger - docs stopped deploying entirely after the previous fix. Dispatch the Docs workflow explicitly via `gh workflow run docs.yml --ref <tag>` instead, and allow workflow_dispatch to deploy regardless of ref so a missed release can be redeployed manually. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126spNDGtqDKMoYtuPT7JfW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-tag.ymlpushes the release tag using the defaultGITHUB_TOKEN. GitHub explicitly blocks events triggered byGITHUB_TOKENfrom starting other workflow runs (anti-recursion protection), sodocs.yml'son.push.tagstrigger never actually fired for any release tag (confirmed viagh run list— no run exists for the0.1.3tag push at all).create-tag.ymlnow explicitly dispatches theDocsworkflow viagh workflow run docs.yml --ref "$version"right after pushing the tag (needsactions: writepermission, added).docs.yml's deploy condition now also acceptsworkflow_dispatchregardless of ref (not just tag pushes), so a missed/broken release's docs can be redeployed manually without cutting a new version.Test plan
gh run list --workflow=docs.ymlthat no run was ever triggered by a tag push (root cause)yaml.safe_loadcreate-tag.ymlshould show aDocsrun triggered byworkflow_dispatchpinned to the new tag, followed by a successful deploy🤖 Generated with Claude Code
https://claude.ai/code/session_0126spNDGtqDKMoYtuPT7JfW