Conversation
…o codex/reuse-acquisition-artifacts # Conflicts: # scripts/build_identity_contract.py # scripts/common.py # tests/test_acquisition_artifacts.py
…o codex/reuse-acquisition-artifacts # Conflicts: # scripts/common.py # tests/test_acquisition_artifacts.py
The scripts assumed POSIX conventions that break on Windows, so the pipeline
could crash, silently drop output, or write broken notes there. Two
repo-authored tests (test_resolve_obsidian_note_path_*) already failed on
Windows for this reason.
Three implicit assumptions are fixed:
- Path separator: str(Path(...)) renders with "\" on Windows.
* common.resolve_obsidian_note_path: compare on Path.parts instead of
str(subdir).startswith(papers_dir) (was duplicating the Research/Papers
prefix on Windows).
* materialize_figure_asset: build the absolute image embed with as_posix()
(backslashes broke the Markdown link).
* plan_figure_table_decisions.source_image_filename: split on [\/] so a
backslash path is not returned whole.
- UTF-8 BOM: read with utf-8-sig in common.load_json_file /
shell_config_value / load_domain_rules, lint_grounding.load_record,
lint_note (note input), write_obsidian_note (--content-file, --lint-json),
and citation_links.build_vault_note_index (a BOM note was dropped from the
index, so wiki-links never resolved).
- CRLF: lint_note.strip_frontmatter tolerates \r and the note is
newline-normalized on read.
Add tests/test_windows_path_encoding.py (11 cases) feeding BOM / CRLF /
backslash inputs; verified they fail on the pre-fix code and pass after.
Suite: 2 failed / 292 passed -> 305 passed. No-op on Linux/macOS and no
public API or output-format change.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Preserve Zebang Cheng's original PR commit while adapting lint gate reporting to the current develop reference hygiene gate.
fix: normalize Obsidian note paths across platforms
…s-path-encoding # Conflicts: # CHANGELOG.md # scripts/common.py # scripts/write_obsidian_note.py
Add paper glossary companion skill.
…gate Improve paper glossary selection and Obsidian workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developsnapshot intomainFull change set: main...develop
Validation
developtree matches the tree from the latest successful PR CI runmain