fix(pwa): bottom nav overlaps content on mobile scroll - #3
Merged
Conversation
On iOS standalone PWAs a position:fixed bottom nav over a nested scroll container (<main overflow-y-auto> inside a height:100% shell) jumps and covers content as you scroll. Make the shell exactly one dynamic viewport tall (.app-shell = 100dvh, 100vh fallback, overflow hidden) and turn the bottom nav into a normal flex child (shrink-0) below the scroll area instead of position:fixed. <main> is now the only scroller and the nav is structurally pinned — no fixed-positioning quirks. Drops the 72px bottom reserve that the fixed nav needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: On the mobile PWA, scrolling down made the bottom nav bar move up and cover ~half the page.
Cause:
position: fixed; bottom: 0on the nav, over a nested scroll container (<main overflow-y-auto>inside aheight:100%shell). iOS standalone PWAs mis-position fixed elements in that setup.Fix: No more
position: fixedon mobile. The app shell is now exactly one dynamic viewport tall (.app-shell=100dvh,100vhfallback,overflow: hidden) and the bottom nav is a normal flex child (shrink-0) below the scroll area.<main>is the only scroller, so the nav is structurally pinned and can't overlap content. Safe-area inset padding is preserved.Verified: typecheck + lint + web build green.
🤖 Generated with Claude Code