Repository navigation
Develop - #15
Merged
Merged
Develop#15
Conversation
`Resolvable<T>` pinned `this` to `StyleSheet<any>`, so assigning a `function` to `attributes` in a subclass failed with TS2339 although the runtime calls it with that subclass. The alias drops `this` on the instance, where TypeScript infers it from the assignment target, and a new `ResolvableOption` keeps it for the options, which have nothing to infer it from.
…n render A subclass can now set its own default prefix with a static, and `prefix`, `attributes` and `renderers` can be getters. Renderers are resolved on every render call, and `getAttributes` is renamed to `getDecoratedAttributes`. BREAKING CHANGE: `prefix` no longer accepts a function. Pass a string, or use a getter.
attach and destroy use the registry of the instance's class, and the static toString, toCSS and destroy use this.registry, so a subclass can declare its own.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.