refactor(authoring): share private npm acquisition verifier - #167
Open
777genius wants to merge 3 commits into
Open
refactor(authoring): share private npm acquisition verifier#167777genius wants to merge 3 commits into
777genius wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
777genius
marked this pull request as ready for review
September 6, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private dual-product candidates need acquisition that binds the expected product, source revision, version, mode and executable digest before returning a cached binary. This change extracts the existing verifier primitives and adds an explicit private adapter with the same per-target lock for warm and cold acquisition, repeated byte verification, owned cleanup and rollback error reporting.
The default bootstrap retains its metadata selection and delegates shared verification. The adapter accepts the existing private candidate mode only. Detached packages, launchers and public activation remain separate dependent work.
Stacked on #165. Verifier checkpoint:
6f3ef8633a41e8fcf7598f1f833787cae46a376a. Current integratione65ed6737fa8156029bfcdeef6707fa5838c2d16includes staging basee707ca59501812f8ef6f259e699305c8aead9d32; npm source is unchanged by that merge. New native CI is pending. The unresolved Windows concurrency gate remains a merge hold.Validation: the integrated bootstrap, private adapter and verifier suites passed 111 tests with zero failures or skips. Independent review found one valid Content-Length compatibility regression. The bounded correction accepts matching decimal lengths with leading zeroes and retains safe size, syntax and digest checks. After correction, the complete seven-suite regression passed 153/153 tests on each of Node 22.23.1 and 24.18.0. The integrator reviewed the correction and reran the affected integrated suites. Payload execution and private packed-wrapper E2E are not proved by these acquisition tests.
The private cache contract assumes cooperating processes and a quiescent namespace controlled by the same user. It does not claim protection from a hostile process under that identity or crash durability.