Skip to content

fix(authoring): reduce compatibility scan work and drain concurrent results - #161

Merged
777genius merged 1 commit into
mainfrom
fix/authoring-compatibility-resource-checkpoint
Sep 6, 2026
Merged

fix(authoring): reduce compatibility scan work and drain concurrent results#161
777genius merged 1 commit into
mainfrom
fix/authoring-compatibility-resource-checkpoint

Conversation

@777genius

@777genius 777genius commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Avoids an extra allocation-heavy traversal of opaque installer JSON fields and prevents concurrent command tests from hanging when a worker encounters invalid output.

The compatibility scanner skips opaque root values while preserving historical installer acceptance, root duplicate diagnostics, syntax/trailing rejection and the existing depth ceiling. Authoring still performs its bounded, context-aware structural pass. Concurrent test workers return raw results; the parent drains them before assertions.

Verified at 1ceafe6, based on main 34befab:

  • Focused conformance, loader and command regressions passed after integration. Implementation race checks passed.
  • The 660 KB regression fixture dropped from 23.48 MB / 840,550 allocations to 2.76 MB / 53. The allocation ceiling fails against the previous implementation. This measures the root-check stage, not total installer memory.
  • Fault subprocesses verify malformed output and stderr failures terminate instead of losing a concurrent result.
  • Independent xhigh review closed both P2 findings with no new P1/P2: 4,488 differential scanner cases, deterministic author cancellation/budget probes, concurrent barriers and lost-send negative control passed. Final required CI, CodeQL, security, docs and Linux/Windows smoke passed.

Follow-up to two confirmed P2 findings from the post-merge audit of #157. Three files, 284 changed lines. No new installer policy, native acquisition change or public authoring release. Revert independently if needed.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@777genius
777genius marked this pull request as ready for review September 6, 2026 06:41
@777genius
777genius merged commit a281a54 into main Sep 6, 2026
16 checks passed
777genius added a commit that referenced this pull request Sep 6, 2026
)

Add metadata-first NTFS acquisition, trusted scratch alias handling and native offline authoring gates for both entrypoints. Preserve default v1 behavior and read-only APFS restriction.

Validated PR head: f0e5995
Validated tree: 845e794
Native evidence: https://github.com/777genius/universal-agent-plugins/actions/runs/34022971411
All PR CI jobs passed. Optional CodeRabbit review was pending; branch rules do not require it. Independent hosted review is complete. Native Windows: 826 test/subtest passes, no required skips. Native Linux: 801 passes, one previously classified optional Unix-socket fixture skip. Independent gpt-6-astra xhigh review accepts this internal checkpoint; both identified test P2 findings are corrected.

Residual risk: a prior isolated Windows scratch_unavailable failure has no established cause. Current public and staged cleanup tests pass, and acquisition fails closed; no causal fix or zero-recurrence claim is made. Public v2 and writable macOS release acceptance remain outside this checkpoint.

Related PRs: #157, #158, #159, #161.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant