fix(authoring): reduce compatibility scan work and drain concurrent results - #161
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
777genius
marked this pull request as ready for review
September 6, 2026 06:41
777genius
added a commit
that referenced
this pull request
Sep 6, 2026
) Add metadata-first NTFS acquisition, trusted scratch alias handling and native offline authoring gates for both entrypoints. Preserve default v1 behavior and read-only APFS restriction. Validated PR head: f0e5995 Validated tree: 845e794 Native evidence: https://github.com/777genius/universal-agent-plugins/actions/runs/34022971411 All PR CI jobs passed. Optional CodeRabbit review was pending; branch rules do not require it. Independent hosted review is complete. Native Windows: 826 test/subtest passes, no required skips. Native Linux: 801 passes, one previously classified optional Unix-socket fixture skip. Independent gpt-6-astra xhigh review accepts this internal checkpoint; both identified test P2 findings are corrected. Residual risk: a prior isolated Windows scratch_unavailable failure has no established cause. Current public and staged cleanup tests pass, and acquisition fails closed; no causal fix or zero-recurrence claim is made. Public v2 and writable macOS release acceptance remain outside this checkpoint. Related PRs: #157, #158, #159, #161.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids an extra allocation-heavy traversal of opaque installer JSON fields and prevents concurrent command tests from hanging when a worker encounters invalid output.
The compatibility scanner skips opaque root values while preserving historical installer acceptance, root duplicate diagnostics, syntax/trailing rejection and the existing depth ceiling. Authoring still performs its bounded, context-aware structural pass. Concurrent test workers return raw results; the parent drains them before assertions.
Verified at 1ceafe6, based on main 34befab:
Follow-up to two confirmed P2 findings from the post-merge audit of #157. Three files, 284 changed lines. No new installer policy, native acquisition change or public authoring release. Revert independently if needed.