Skip to content

feat(authoring): add atomic standard Skills lifecycle - #159

Merged
777genius merged 1 commit into
mainfrom
feat/standard-skills-checkpoint
Sep 6, 2026
Merged

feat(authoring): add atomic standard Skills lifecycle#159
777genius merged 1 commit into
mainfrom
feat/standard-skills-checkpoint

Conversation

@777genius

@777genius 777genius commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Adds atomic skills init <name> [package-path] --description <text> and shared-profile skills validate [package-path] through both internal authoring entrypoints. Omitted paths bind exactly to the current directory. Creation stages and validates one generated Skill, publishes without replacement, preserves existing siblings and reports committed state even when a later check fails.

Follows merged #157 and #158. Based on main at 1b77dc8. Default public v1 behavior remains gated; this does not release v2 or enable deferred commands.

Validation at ce4eeb9:

  • Integrated authoring and factory suites passed, including installer projection and template syntax probes. The pre-existing denied-parent test skips under root; it remains enforced by ordinary-user CI.
  • The implementation run passed 22 native invocations through both actual binaries under calibrated Linux effect guards, plus focused race tests. Guards deny process/network/profile effects and restrict writes to the explicit init source and private scratch; they are not syscall traces.
  • Both clean committed binaries now also passed the 22-case guarded journey with matching reports and generated trees. Build provenance records exact revision, vcs.modified=false and binary hashes. Independent xhigh review found no new P1/P2 after focused race tests, three additional fault probes and guard calibration. Final required CI, CodeQL, security, docs and Linux/Windows installer smoke passed. The draft bot review skip is not model review evidence. Native Windows/macOS execution and Phase 6 release remain separate gates.

The diff is approximately 1,800 lines including tests. Revert independently to remove the new Skills lifecycle while retaining package authoring and static readiness. An over-budget acquisition remains incomplete according to the existing bounded reader contract; uncaptured siblings are never reported as verified.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@777genius
777genius marked this pull request as ready for review September 6, 2026 06:06
@777genius
777genius merged commit 34befab into main Sep 6, 2026
16 checks passed
777genius added a commit that referenced this pull request Sep 6, 2026
)

Add metadata-first NTFS acquisition, trusted scratch alias handling and native offline authoring gates for both entrypoints. Preserve default v1 behavior and read-only APFS restriction.

Validated PR head: f0e5995
Validated tree: 845e794
Native evidence: https://github.com/777genius/universal-agent-plugins/actions/runs/34022971411
All PR CI jobs passed. Optional CodeRabbit review was pending; branch rules do not require it. Independent hosted review is complete. Native Windows: 826 test/subtest passes, no required skips. Native Linux: 801 passes, one previously classified optional Unix-socket fixture skip. Independent gpt-6-astra xhigh review accepts this internal checkpoint; both identified test P2 findings are corrected.

Residual risk: a prior isolated Windows scratch_unavailable failure has no established cause. Current public and staged cleanup tests pass, and acquisition fails closed; no causal fix or zero-recurrence claim is made. Public v2 and writable macOS release acceptance remain outside this checkpoint.

Related PRs: #157, #158, #159, #161.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant