fix(retrieval): start reconciliation lease after attestation - #71
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesReconciliation Lease Timing
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Lease issuance now accounts for attestation time while preserving the configured TTL, and no concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit clocks the attestation run Comment |
Active retrieval reconciliation could return a lease that was already expired when physical Qdrant attestation took longer than the 30-second lease TTL. The reconciliation flow now advances its logical timestamp by measured monotonic elapsed time and starts the renewed lease after attestation completes.
A regression test models a 40-second attestation and verifies that the renewed lease retains its full 30-second TTL.
Validation:
uv run --extra dev pytest tests/server/test_active_reconciliation_identity.py tests/server/test_retrieval_profile_runtime.py tests/server/test_retrieval_profile_admin_command.py -q- 32 passedgit diff --checkpassedSummary by CodeRabbit
Bug Fixes
Tests