fix(retrieval): suppress weak lexical fusion hits - #70
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PostgreSQL lexical retrieval lane now normalizes Unicode and punctuation, removes low-information terms, matches canonical and folded aliases, enforces minimum relevance, and rejects empty queries. Tests cover keyword matching, dense-only retrieval, score fusion, and decoy exclusion. ChangesKeyword retrieval
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The keyword retrieval changes include normalization, matching, and fusion coverage with no unresolved actionable issue identified. The change is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit sorts the words with care Comment |
Russian and punctuation-heavy queries could promote broad substring matches into weighted RRF, displacing relevant dense candidates. This change normalizes lexical terms with Unicode word extraction and casefolding, removes a bounded RU/EN low-information word set, and requires two informative matches for multi-term keyword queries while preserving single-term and dense-only retrieval.
It also retains an explicit trigram-indexable PostgreSQL prefilter and preserves escaped punctuation-bearing signals such as
100%, so they cannot match decoys such as1000.Real frozen-corpus retrieval-only A/B on the same 39 paired requests:
The A/B reused sealed baseline responses and invoked no answer model. A test-only adapter bypassed release-lease admission because baseline and candidate releases cannot own the same active profile simultaneously; ranking, PostgreSQL/Qdrant lanes, canonical hydration, and response bounds remained production implementations.
Validation:
80ad724487e14b18d38872e795d7944d78954c74: approve, no blocking findingsSummary by CodeRabbit