fix(release): keep SDK qualification releases in draft - #67
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
777genius
changed the base branch from
feat/retrieval-thread-selector-v3
to
main
September 10, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK qualification currently publishes every newly built release. Add a publish_release boolean defaulting to false so qualification retains a draft until explicit approval of that version.
Draft runs verify downloaded bytes and retain separate mutable qualification evidence. Public release verification remains strict and separate. Explicit publication preserves the existing single-edit and reconciliation behavior. Draft identity checks compare stable IDs, names, sizes and digests, excluding download counters and asset ordering.
Validation: 133 release workflow tests passed, including no-publication defaults, invalid input rejection, increasing counters, reordered assets and identity/content drift rejection. Independent review found the counter issue, now reproduced and fixed. Ruff and diff checks passed. No live release was created or published.
Stacked on #66; the diff is limited to release workflow, helper, tests and documentation.