feat(facts): add canonical relation transaction ports - #65
Merged
Merged
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
777genius
force-pushed
the
refactor/feature-slice-architecture-guards
branch
from
September 9, 2026 02:07
75add53 to
558be44
Compare
777genius
force-pushed
the
refactor/memory-fact-relation-ports
branch
from
September 9, 2026 02:13
271b221 to
18f20e4
Compare
777genius
changed the base branch from
refactor/feature-slice-architecture-guards
to
main
September 9, 2026 02:13
777genius
marked this pull request as ready for review
September 9, 2026 02:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add feature-owned generic fact relation commands, snapshots, transaction ports and adapters over the existing canonical PostgreSQL rows. Link/list/unlink share the fact UoW, preserving replay, visibility, filtering and lifecycle rules without fact revisions or projection events.
The independent P1 review exposed an existing exact-thread FK requirement. The adapter now persists thread_id for same-thread endpoints, including global/global. Global/thread and different-thread links are rejected before replay or writes. This corrects the earlier inaccurate cross-thread allowance claim; no migration or schema expansion is introduced. Temporal integrity remains unchanged.
Validation: initial 140 functional and 67 architecture tests passed, followed by 52 focused remediation tests. Final disposable PostgreSQL acceptance passed in 11.02 seconds at 18f20e4, covering database contention, uniqueness, replay, rollback and extended thread cases. The temporary container was removed. Filter-before-limit and shared canonical rollback assertions were strengthened. Ruff and size checks passed.
Full CI passed before the bounded thread correction at 271b221 (34287913910). The complete final patch is byte-identical before and after rebase onto current main. Per owner request for quick stable delivery without long repeated checks or hosting load, reuse previous full CI plus focused correction evidence; no final exact-head full-suite pass is claimed. Final independent review approved exact commit 18f20e4 with no actionable P0/P1/P2 findings.
This persistence/application checkpoint does not switch HTTP consumers or complete all feature canonicalization. No further feature work, provider calls or dependencies are included.