Skip to content

feat(facts): add canonical relation transaction ports - #65

Merged
777genius merged 2 commits into
mainfrom
refactor/memory-fact-relation-ports
Sep 9, 2026
Merged

777genius merged 2 commits into
mainfrom
refactor/memory-fact-relation-ports

Conversation

@777genius

@777genius 777genius commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Add feature-owned generic fact relation commands, snapshots, transaction ports and adapters over the existing canonical PostgreSQL rows. Link/list/unlink share the fact UoW, preserving replay, visibility, filtering and lifecycle rules without fact revisions or projection events.

The independent P1 review exposed an existing exact-thread FK requirement. The adapter now persists thread_id for same-thread endpoints, including global/global. Global/thread and different-thread links are rejected before replay or writes. This corrects the earlier inaccurate cross-thread allowance claim; no migration or schema expansion is introduced. Temporal integrity remains unchanged.

Validation: initial 140 functional and 67 architecture tests passed, followed by 52 focused remediation tests. Final disposable PostgreSQL acceptance passed in 11.02 seconds at 18f20e4, covering database contention, uniqueness, replay, rollback and extended thread cases. The temporary container was removed. Filter-before-limit and shared canonical rollback assertions were strengthened. Ruff and size checks passed.

Full CI passed before the bounded thread correction at 271b221 (34287913910). The complete final patch is byte-identical before and after rebase onto current main. Per owner request for quick stable delivery without long repeated checks or hosting load, reuse previous full CI plus focused correction evidence; no final exact-head full-suite pass is claimed. Final independent review approved exact commit 18f20e4 with no actionable P0/P1/P2 findings.

This persistence/application checkpoint does not switch HTTP consumers or complete all feature canonicalization. No further feature work, provider calls or dependencies are included.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@777genius
777genius force-pushed the refactor/memory-fact-relation-ports branch from 271b221 to 18f20e4 Compare September 9, 2026 02:13
@777genius
777genius changed the base branch from refactor/feature-slice-architecture-guards to main September 9, 2026 02:13
@777genius
777genius marked this pull request as ready for review September 9, 2026 02:16
@777genius
777genius merged commit 723a677 into main Sep 9, 2026
2 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant