Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have forked the zeroperl repo to support a WASM build of my WebDyne framework. During that build I saw repeated traps in the Cloudflare WASM provider which were traced to a reference count issue
This PR seeks to fix that issue.
zeroperl_hash_deletedecrements the value returned byhv_delete(..., 0),but Perl has already made that return value mortal. The extra decrement can
release a value still retained by another caller when the temporary scope drains.
Use
hv_delete(..., G_DISCARD)so Perl owns deletion cleanup, and check keyexistence beforehand to preserve the boolean result, including undef-valued keys.
The exported signature is unchanged.
Adds a native libperl regression using the production function extracted
verbatim. It checks retained values after temporary cleanup, exactly one DESTROY
per object, undef values, missing/repeated deletions and invalid arguments.
Validation on native Perl 5.44.0, macOS arm64:
git diff --checkpasses.