fix(acp): launch Windows command shims safely - #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Route Windows .cmd and .bat ACP processes through cmd.exe with explicit argv escaping. This fixes npm-installed agents such as OpenCode failing with spawn EINVAL while preserving direct spawning for native executables and non-Windows hosts.
The same normalization is applied to ACP agent and terminal processes. shell=true is deliberately avoided.
Testing
Risk
ACP process spawning is security-sensitive. The wrapper is restricted to .cmd/.bat on Windows and explicitly escapes cmd.exe metacharacters.
Screenshot/Recording
Not applicable (process-launch fix).
Checklist