vms-926: adhoc-only negctl wall bump 1800->2700 (env-gated, sharded gate untouched) - #1236
Merged
Merged
Conversation
… keep sharded gate tight The adhoc negctl rail (negctl-adhoc.yml) runs the FULL ~124-suite pristine control UNSHARDED plus one full-suite boot per named defect. Measured today: under TCG contention a single 124-suite boot completes only ~89/124 in the 1800s wall (~20s/suite -> 124 needs ~2510s), self-exits (exit 1), and the run-order tail (imgact + tcpip + ssh) reports a false-red rc=MISSING mass. This flaked ~half of today's adhoc proofs and is the keystone blocking the whole negctl-proof pipeline (#1225/#1226 re-anchors, #1231/#1235 dispatches). Fix (vms-926 lineage, 600->1800 -> now 1800->2700), env-gated so it touches ONLY the adhoc path: - run_facility_negctl.sh: both the pristine control (line ~264) and each defect run (line ~273) now take KE_WALL_TIMEOUT="${NEGCTL_WALL:-1800}". Default 1800 is UNCHANGED, so the sharded CI negctl gate (kernel-executive-facility-negative-controls-shard, 22 shards @ 50m, which does NOT set NEGCTL_WALL) stays exactly as tight as before. - negctl-adhoc.yml: sets NEGCTL_WALL=2700 and raises the job timeout 60->100m (worst case 250s build + 2700 pristine + 2700 defect ~= 94m). Both walls move together because pristine and each defect boot the full suite set at the same cost -- bumping only one just relocates the flake to the other. Guards honored: the raise is a per-boot CEILING (an uncontended boot still finishes in ~250s and never reaches the wall, so nothing is slowed); the rc=124 outer fail-loud is preserved (message now cites ${NEGCTL_WALL}); ci.yml is untouched (0 changes) so the sharded graduation gate is not loosened; the raw kernel-executive-shard leg (600s run_tests.sh, no override) is likewise unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the adhoc negctl per-boot wall 1800→2700 (env-gated via
NEGCTL_WALL, default 1800), the keystone unblock for the negctl-proof pipeline.Why
The adhoc path (
negctl-adhoc.yml) runs the FULL ~124-suite pristine control UNSHARDED + one full-suite boot per defect. Measured today: under TCG contention a 124-suite boot completes only ~89/124 in the 1800s wall (~20s/suite ⇒ 124 needs ~2510s), self-exits, and the run-order tail (imgact + tcpip + ssh) reports a false-redrc=MISSINGmass. This flaked ~half of today's adhoc proofs and blocks #1225/#1226 re-anchors + #1231/#1235 dispatches.Change (vms-926 lineage: 600→1800, now 1800→2700)
run_facility_negctl.sh: pristine control and each defect run takeKE_WALL_TIMEOUT="${NEGCTL_WALL:-1800}". Both walls move together (pristine + each defect boot the full set at equal cost; bumping one alone just relocates the flake).negctl-adhoc.yml: setsNEGCTL_WALL=2700+ job timeout 60→100m (worst case 250s build + 2700 + 2700 ≈ 94m).Guards honored
NEGCTL_WALLis 1800, unchanged. The sharded CI negctl gate (kernel-executive-facility-negative-controls-shard, 22 shards @ 50m) does NOT setNEGCTL_WALL→ identical budget. ci.yml has 0 changes. The rawkernel-executive-shardleg (600srun_tests.sh, no override) is also unaffected.${NEGCTL_WALL}).Proof
Dispatching an adhoc run against this branch to confirm the 2700 pristine completes all 124 suites (no rc=MISSING) under current contention.
🤖 Generated with Claude Code