vms-387: re-anchor the tcpip config-store pair on the shared ODS-2 reader - #1224
Merged
Merged
Conversation
…ader (OPTION 1) test_syssvc_tcpip_config_acp and test_syssvc_tcpip_host_acp were in-scope negctl suites with NO can-fail anchor (coverage-gate FAIL). They carry no tcpip-distinct product code: both call the shared rms_textfile primitive (rms_textfile_open/append_line) DIRECTLY, so their only honest anchor is that shared reader. The existing loginout-acp-auth-from-ods2 defect already breaks exactly it -- rms_textfile_open declares FAB$C_VAR instead of FAB$C_STMLF, misframing every stream-LF $GET into garbage. Runtime measurement (adhoc run 34776754434) proves that one misframe reddens all of loginout_acp AND the tcpip config/host/service stores' read-backs, because host_store_has()/count_records_with() ride the same rms_textfile_open()+getline. Its isolation=isolated claim (loginout only) predated the tcpip suites (vms-402/vms-210) and was stale. Re-anchor by widening that defect's honest can-fail set: - suites_red += test_syssvc_tcpip_config_acp test_syssvc_tcpip_host_acp - name the 7 tcpip read-back assertions it reddens (2 require_fail + 5 knock_on) - add the /* negctl: loginout-acp-auth-from-ods2 */ source markers above the two require_fail CHECKs (the pairing floor, vms-d894) - rewrite facility/why/knock_on_why to describe the shared reader across both facilities and why the writers/dismount/binary-SYSUAF paths stay green. A dedicated append-side defect was rejected: it would also redden test_syssvc_ident's OPCOM writer path (a name/scope lie). This READ-misframe touches only rms_textfile_open readers, not ident. test_syssvc_tcpip_service_db also reddens under it but carries its own anchor, so it is reported as a non-gating lint line (vms-49f), not claimed here. selftest: both coverage checks now clear the tcpip pair; every require_fail/ knock_on text exists literally in source; anchor injects + no-op-reapply has teeth. Runtime exact-red set proven separately before flagging for reap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HMDFjHCqxDuXgbyxNU572h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Gives
test_syssvc_tcpip_config_acp+test_syssvc_tcpip_host_acpa real can-fail negctl anchor (they were in-scope coverage-gate FAILs with no anchor), by widening the existingloginout-acp-auth-from-ods2defect to honestly name them.Why OPTION 1 (re-anchor) not scope-out
The tcpip pair carries no tcpip-distinct product code — both tests call the shared
rms_textfileprimitive directly (rms_textfile_open/append_line). Their only honest can-fail anchor is that shared reader.The
loginout-acp-auth-from-ods2defect already breaks exactly it (rms_textfile_opendeclaresFAB$C_VARinstead ofFAB$C_STMLF, misframing every stream-LF$GET). Runtime measurement (adhoc run 34776754434) proves that one misframe reddens loginout_acp AND all three tcpip stores' read-backs — becausehost_store_has()/count_records_with()ride the samerms_textfile_open()+getline. Itsisolation=isolatedclaim (loginout only) predated the tcpip suites and was stale.Change
suites_red += test_syssvc_tcpip_config_acp test_syssvc_tcpip_host_acp/* negctl: loginout-acp-auth-from-ods2 */source markers above the two require_fail CHECKs (the pairing floor, vms-d894)A dedicated append-side defect was rejected: it would also redden
test_syssvc_ident's OPCOM writer path (a name/scope lie). This READ-misframe touches onlyrms_textfile_openreaders.test_syssvc_tcpip_service_dbalso reddens under it but has its own anchor → reported as a non-gating lint line (vms-49f), not claimed here.Proof
🤖 Generated with Claude Code
https://claude.ai/code/session_01HMDFjHCqxDuXgbyxNU572h