Skip to content

vms-387: re-anchor the tcpip config-store pair on the shared ODS-2 reader - #1224

Merged
baron-3dl merged 1 commit into
mainfrom
work/vms-tcpip-reanchor
Sep 13, 2026
Merged

baron-3dl merged 1 commit into
mainfrom
work/vms-tcpip-reanchor

Conversation

@baron-3dl

Copy link
Copy Markdown
Contributor

What

Gives test_syssvc_tcpip_config_acp + test_syssvc_tcpip_host_acp a real can-fail negctl anchor (they were in-scope coverage-gate FAILs with no anchor), by widening the existing loginout-acp-auth-from-ods2 defect to honestly name them.

Why OPTION 1 (re-anchor) not scope-out

The tcpip pair carries no tcpip-distinct product code — both tests call the shared rms_textfile primitive directly (rms_textfile_open/append_line). Their only honest can-fail anchor is that shared reader.

The loginout-acp-auth-from-ods2 defect already breaks exactly it (rms_textfile_open declares FAB$C_VAR instead of FAB$C_STMLF, misframing every stream-LF $GET). Runtime measurement (adhoc run 34776754434) proves that one misframe reddens loginout_acp AND all three tcpip stores' read-backs — because host_store_has()/count_records_with() ride the same rms_textfile_open()+getline. Its isolation=isolated claim (loginout only) predated the tcpip suites and was stale.

Change

  • suites_red += test_syssvc_tcpip_config_acp test_syssvc_tcpip_host_acp
  • name the 7 reddening tcpip read-back assertions (2 require_fail + 5 knock_on)
  • add /* negctl: loginout-acp-auth-from-ods2 */ source markers above the two require_fail CHECKs (the pairing floor, vms-d894)
  • rewrite facility/why/knock_on_why for the shared reader across both facilities; document why writers/dismount/binary-SYSUAF stay green.

A dedicated append-side defect was rejected: it would also redden test_syssvc_ident's OPCOM writer path (a name/scope lie). This READ-misframe touches only rms_textfile_open readers. test_syssvc_tcpip_service_db also reddens under it but has its own anchor → reported as a non-gating lint line (vms-49f), not claimed here.

Proof

  • selftest: both coverage checks now clear the tcpip pair; every require_fail/knock_on text exists literally in source; anchor injects + no-op-reapply has teeth.
  • Runtime exact-red set (10 assertions across the 3 named suites, service_db excluded-and-flagged) proven via adhoc before flagging for reap.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HMDFjHCqxDuXgbyxNU572h

…ader (OPTION 1)

test_syssvc_tcpip_config_acp and test_syssvc_tcpip_host_acp were in-scope
negctl suites with NO can-fail anchor (coverage-gate FAIL). They carry no
tcpip-distinct product code: both call the shared rms_textfile primitive
(rms_textfile_open/append_line) DIRECTLY, so their only honest anchor is that
shared reader.

The existing loginout-acp-auth-from-ods2 defect already breaks exactly it --
rms_textfile_open declares FAB$C_VAR instead of FAB$C_STMLF, misframing every
stream-LF $GET into garbage. Runtime measurement (adhoc run 34776754434) proves
that one misframe reddens all of loginout_acp AND the tcpip config/host/service
stores' read-backs, because host_store_has()/count_records_with() ride the same
rms_textfile_open()+getline. Its isolation=isolated claim (loginout only)
predated the tcpip suites (vms-402/vms-210) and was stale.

Re-anchor by widening that defect's honest can-fail set:
- suites_red += test_syssvc_tcpip_config_acp test_syssvc_tcpip_host_acp
- name the 7 tcpip read-back assertions it reddens (2 require_fail + 5 knock_on)
- add the /* negctl: loginout-acp-auth-from-ods2 */ source markers above the
  two require_fail CHECKs (the pairing floor, vms-d894)
- rewrite facility/why/knock_on_why to describe the shared reader across both
  facilities and why the writers/dismount/binary-SYSUAF paths stay green.

A dedicated append-side defect was rejected: it would also redden
test_syssvc_ident's OPCOM writer path (a name/scope lie). This READ-misframe
touches only rms_textfile_open readers, not ident. test_syssvc_tcpip_service_db
also reddens under it but carries its own anchor, so it is reported as a
non-gating lint line (vms-49f), not claimed here.

selftest: both coverage checks now clear the tcpip pair; every require_fail/
knock_on text exists literally in source; anchor injects + no-op-reapply has
teeth. Runtime exact-red set proven separately before flagging for reap.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HMDFjHCqxDuXgbyxNU572h
@baron-3dl
baron-3dl merged commit b64d6b5 into main Sep 13, 2026
124 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant