vms-ac3: anchor test_syssvc_rms_workload (rms-dirfind-exact-version-ignored) - #1222
Merged
Conversation
…gnored) Closes the rms_workload unanchored-suite gap and doubles as live validation of vms-b8a2 (its require_fail label carries a ';N' version spec that the old selftest ';.*' truncation would have dropped). New defect rms-dirfind-exact-version-ignored: forces acp_dirfind_scan_cb()'s exact-version gate (kernel-core/vmsfs_acp.c) to ignore the requested version, so an explicit-version open matches whichever entry the newest-first scan reaches first -- A4 (;1) wrongly reads the ;2 payload, A6 (;3, nonexistent) returns NORMAL instead of RMS$_FNF. require_fail "sys$open WKOBJ.OBJ;1 still reads the ;1 payload 'V1'" + knock_on "...;3 -> RMS$_FNF (fail-honest)"; anchors above the A4/A6 checks. Floor 149->150. Static-verified: bash -n clean; selftest anchors + BROKEN-FIXTURE teeth confirmed (the ';N' labels now match, post-b8a2); test_syssvc_rms_workload off both unanchored FAIL lists; no net-new FAILs vs origin/main. register-continue + identcont left at their origin/main baseline (register-continue's real fix is a separate option-1 re-anchor PR, so identcont is never orphaned). Runtime redden proof via negctl-adhoc on the fixed rail (following). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HMDFjHCqxDuXgbyxNU572h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the
test_syssvc_rms_workloadunanchored-suite gap, and doubles as live validation of vms-b8a2 — the new defect'srequire_faillabel carries a;Nversion spec that the old selftestsed 's/;.*//'truncation would have dropped.New defect
rms-dirfind-exact-version-ignored: forcesacp_dirfind_scan_cb()'s exact-version gate (kernel-core/vmsfs_acp.c) to ignore the requested version, so an explicit-version open matches whichever entry the newest-first scan reaches first — A4 (;1) wrongly reads the;2payload, A6 (;3, nonexistent) returns NORMAL instead ofRMS$_FNF.require_fail: "sys$open WKOBJ.OBJ;1 still reads the ;1 payload 'V1'";knock_on_fail: "...;3 → RMS$_FNF (fail-honest)". Anchors above the A4/A6 checks. Floor 149→150.Scope / honesty
register-continue-identity-dropped + test_syssvc_identcont are left at their origin/main baseline (register-continue stays a dead-anchor here) — its real fix is a separate option-1 re-anchor PR (inject at the now-unconditional identity-copy site, keeping identcont covered), so identcont is never orphaned on main between PRs.
Verified
bash -nclean; selftest — anchor + BROKEN-FIXTURE teeth confirmed, the;Nlabels now match (post-b8a2),test_syssvc_rms_workloadoff both unanchored FAIL lists; no net-new FAILs vs origin/main. Runtime redden proof (A4/A6 redden on the real /dev/vms) via negctl-adhoc on the vms-926-fixed rail — following; I'll flag when green.🤖 Generated with Claude Code
https://claude.ai/code/session_01HMDFjHCqxDuXgbyxNU572h