format hellomessage with hex#3
Open
317787106 wants to merge 5 commits intohotfix/add_log_supportfrom
Open
Conversation
0xbigapple
reviewed
Oct 9, 2025
| String[] lines = helloMessage.toString().split("\n"); | ||
| StringBuilder sb = new StringBuilder(); | ||
| for (String line : lines) { | ||
| if (line.contains("nodeId")) { |
There was a problem hiding this comment.
Is it possible that using string matching may unintentionally replace unrelated content? I think it's not a good way for 3 reasons：1. If there are multiple fields containing "nodeId" in different contexts 2. If helloMessage add a new filed which name contains "nodeId" 3. If the proto toString() format changes in future?
…port feat(log): add instruction that how to use log correctly and support JDK17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.