Skip to content

CI: engine-smoke checks that the engine imports, instead of a grep that could not fail - #8

Merged
jehrr merged 1 commit into
mainfrom
fix/engine-smoke-import-check
Sep 24, 2026
Merged

jehrr merged 1 commit into
mainfrom
fix/engine-smoke-import-check

Conversation

@jehrr

@jehrr jehrr commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

The engine-smoke job's guard grepped smoke.log for <engine>_scraper could not be imported. This suite never prints that phrase, so the step could not fail, and a broken engine import would have passed CI. That is the "skipped reads like passing" hole the job exists to close.

Evidence (2026-09-24): each repo's suite was run on a fresh clone of main, in a venv with only requirements.txt, capturing stdout as | tee does. The phrase appeared in the logs of 2 of 31 repos (amazon, opensea). This repo's suite names a skipped engine in its own words.

Fix: the step now runs .venv/bin/python -c "import <engine>_scraper". That does not depend on the suite's wording, and it fails by name because each engine imports its driver at module level.

Controls, run locally on this repo:

  • with the engine absent, the import fails (ImportError), so the check can fire;
  • with the engine installed, the import succeeds, so it does not fire on a healthy job.

This PR's own engine-smoke jobs are the third check: they must stay green.

Not changed: the suite itself, and every other step.

🤖 Generated with Claude Code

…at could not fail

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jehrr
jehrr merged commit d5ac26b into main Sep 24, 2026
7 checks passed
@jehrr
jehrr deleted the fix/engine-smoke-import-check branch September 24, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant