CI: engine-smoke checks that the engine imports, instead of a grep that could not fail - #8
Merged
Merged
Conversation
…at could not fail Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
engine-smokejob's guard greppedsmoke.logfor<engine>_scraper could not be imported. This suite never prints that phrase, so the step could not fail, and a broken engine import would have passed CI. That is the "skipped reads like passing" hole the job exists to close.Evidence (2026-09-24): each repo's suite was run on a fresh clone of
main, in a venv with onlyrequirements.txt, capturing stdout as| teedoes. The phrase appeared in the logs of 2 of 31 repos (amazon, opensea). This repo's suite names a skipped engine in its own words.Fix: the step now runs
.venv/bin/python -c "import <engine>_scraper". That does not depend on the suite's wording, and it fails by name because each engine imports its driver at module level.Controls, run locally on this repo:
ImportError), so the check can fire;This PR's own
engine-smokejobs are the third check: they must stay green.Not changed: the suite itself, and every other step.
🤖 Generated with Claude Code