Repository navigation
Remove donor-site leftovers from docs, templates and comments - #6
Merged
Merged
Conversation
- captcha_solver.py: docstring claimed no challenge was ever observed and the "NOT here" section described another site's headless Akamai 403; both now state Vrbo's measured Bot-or-Not/DataDome behaviour, and the "No DataDome solver" section the docstring referenced now exists. "lots"/"lot links" -> properties. - CONTRIBUTING.md: site-change anchors, pinned-property list, akamai marker note, canary note, live-run note, form and scope wording rewritten for Vrbo from README/TROUBLESHOOTING/product_parser. - Issue templates: bug-report hints and site-change template rewritten for Vrbo (cards, storefronts, stop_reasons); example URL/command fixed. - diff_runs.py: donor example filenames, a note on a `sold` column this repo lacks, and a docstring listing absent columns and JSON-LD. - .gitignore: catawiki_products.* -> vrbo_products.* (engines' --out default). - SECURITY.md: protection named as Vrbo's, releases exist, README section name corrected. - CHANGELOG: entry under Unreleased; removed an empty duplicate Unreleased heading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jehrr
force-pushed
the
fix/donor-leftovers
branch
from
September 28, 2026 19:50
e27ac6c to
abaa399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text copied from the repos this one was bootstrapped from, describing another site as if it were Vrbo. Replacements are taken from this repo's own README, TROUBLESHOOTING, product_parser and canary; nothing new was measured.
Fixed
divSRPContentProducts,imgLeg-c,span.flip, a DETAIL-pagewindow.__cache); the pinned-properties list was an auction site's (bid kinds, reserve lots, zero-width price placeholder,favorite_count,bid_count, 100-page cap, 24 suggested lots, headless 403); theakamainote said the string is only in a response header, contradicting this repo's own 899 KB-page measurement; the canary note said the browser build is the gate (the README corrects that); the live-run note said a datacentre gets no response at all. All rewritten for Vrbo. Pyppeteer anecdote now names its sibling (tokopedia-scraper). Form/scope wording: no "registration form", no category listings.__NEXT_DATA__payload, lots, reserve flags and/en/locales; rewritten around Vrbo's cards, the two price-container spellings, storefronts,stop_reasons. Example URLvrbo.com/en/c/333-watches/--out grills/ "96 products" replaced.watches,girls_), asold/sold_is_floor/"terjual" paragraph for a column this repo lacks, and a docstring listingoriginal_price/discount_pct/in_stockand JSON-LD provenance. Docstring now lists the real tracked fields andstay_changed.catawiki_products.*→vrbo_products.*(the engines' argparse--outdefault).[Unreleased]; removed an empty duplicate[Unreleased]heading. No version bump.Kept, deliberately
.gitignorecraigslist-scraper note and captcha_solver's farfetch-scraper notes (and the Kohl's example) — sibling provenance that names its source.[0.1.0]CHANGELOG section untouched.Checks
python3 smoke_test.pyOK before and after (pyppeteer/selenium groups skipped locally, engine absent).ci_checks.py --secret-checkand--help-check --sample-checkOK.🤖 Generated with Claude Code