Repository navigation
Conversation
|
PR #14786's |
|
Approved All five fixture functions retain their serial annotation, guard scope, and child-environment assertions. The shared guard preserves byte strings when it restores the test environment. The watchdog collateral is a test comment. An independent Unix probe compiled the exact helper with its tests and verified all three cases. The byte-restoration case failed under an isolated negative control using the former The local macOS strict lint reports |
|
The approved EnvGuard and Guide heads were still merge-ready in Forge, with all exact-head CI checks passed. A bounded read of Fleet's natural dispatch activity since 13:29 UTC found 24 captain claim refusals for this PR and 8 for #14789. Captain The emitting captain reports Loom |
Summary
EnvGuard::clearin all five unregistered-workspace tests. Preserve the serial annotations, guard lifetimes, and existing child-environment assertions.GH_CONFIG_DIRasString, which discarded existing paths containing non-UTF-8 bytes.Test Plan
TDD: no — the new shared-guard regression was added with the migration. The baseline probe reproduced byte loss in all three old guards, and the new regression fails under a test-only copy that restores their lossy snapshot behavior.
GH_CONFIG_DIR.cargo fmt --all -- --checkandgit diff --checkpassed. Strict Clippy on macOS reports the existingSampler.self_spawndead-code warning in unchangedfleet_sync/git_spawn_log.rs. The field is read by a Linux-only method. Hosted CI runs this check on Linux.Closes #14783
Loom-Issue: #14783
loom dashboard