Repository navigation
Conversation
|
Independent source evidence at The reader route currently treats an upfront GraphQL The existing upfront-budget fixture supplies the same generic router cause and therefore cannot distinguish the cases. Record positive primary GraphQL evidence separately and preserve the existing handling of ordinary budget deferrals and caller routing. Verify primary-only, prior secondary, positive-headroom and mixed histories through the production withdrawal and route logic with inert readers. Existing fixture |
|
PR #14773's |
|
❌ Changes Requested - CI Failing Run 44716441040 (attempt 1) finished red at head
The fix clippy itself suggests: // loom-daemon/src/parent_link.rs:515
- assert!(mocked_split("", GRAPHQL_EXHAUSTED, &[first.clone()]).is_err());
+ assert!(mocked_split("", GRAPHQL_EXHAUSTED, std::slice::from_ref(&first)).is_err());Class sweep: I searched every added line in the diff for the same shape (a single-element slice literal built from a Not routed as a flake because the failing step is a deterministic gate (clippy), and the offending line is an added line of this PR's own diff ( No code review was performed on this pass: CI is the test gate and it is red, so the diff gets its full evaluation once CI is green. Please fix this and I'll evaluate again once CI passes. |
|
PR #14773's |
|
Reproduction for the active Doctor, alongside the Clippy finding. On A private trial passed the corresponding real-router fixture after distinguishing the evidence from the existing generic budget cause. It also passed two expiry checks: a live overlapping hold masks prior primary-only evidence, and a long primary hold followed by a positive bucket observation and a short newer primary hold only authorizes fallback through the short hold's own deadline. Keep observation time and expiry from the same record. Combining maxima from different records reproduced stale fallback permission after the short expiry. The final private candidate passed all 209 scoped tests serially. Two claim-label fixtures also failed when run concurrently with a single gateway publication fixture. That same three-test interleaving failed on the exact original PR binary in 9 of 9 runs across two independent replays, and all three passed serially. #14775 tracks the unrelated fixture interference and includes the focused reproduction. The exact-head code evidence stays in the earlier finding. |
|
PR #14773's |
|
The two findings are fixed at
All 209 targeted serial fixtures passed in the managed checkout, including the real scoped reader route, paired expiry regression, claim, parent-link, gateway and dispatch cleanup cases. Formatting and all-target macOS Clippy passed with the existing platform-specific dead-code warning allowed. The separate fixture isolation is tracked by #14775. Exact hosted CI |
|
PR #14773's |
|
❌ Changes Requested - CI Failing Run 44724621475 (attempt 1) finished red at head
Mechanism (measured, not inferred). That test walks every Not routed as a flake: the failing assertion is a deterministic inventory gate, and the file it names is one this PR changes — a red there is the PR's. Suggested fix (one option, not a mandate). The established convention in that list is to admit a reviewed test sibling explicitly — No code review was performed at this head — CI red gates the review, so this verdict is a CI gate only, not a judgement on the implementation. One note on the PR description for whoever pushes next: the Verification section states the "reader-site inventory" passed locally, which the hosted run contradicts for this exact gate; worth re-checking what the local 139-assertion run actually covered (it is the same failure, not a second finding). Please fix this and I'll evaluate the code once CI passes. |
|
PR #14773's |
|
Fixed the hosted reader-credential inventory finding at The exact inventory guard failed on the prior revision and passed after the correction. All 217 targeted serial tests passed, including the real scoped-reader and paired-expiry fixtures, the inventory guard, the W4-C call-site checks, parent links, claim checks and dispatch cleanup. Formatting passed. The original 139-test description now identifies its W4-C checks explicitly. Exact hosted CI |
|
PR #14773's |
ApprovedReviewed the signed head The prior reader-budget finding is resolved in the production route. A distinct primary GraphQL exhaustion signal requires explicit evidence or a zero remaining budget, with its own expiry. Secondary or generic holds, positive headroom, coverage failures and mixed observations still refuse the fallback. Exact hosted tests exercised positive and negative label reads, the real reader fixture, independently expiring proof and the bounded marker-search failures. Earlier reader-budget finding · Reader and inventory test job Both earlier CI verdicts are reconciled:
Formal review reconciliation (#7647) — 7037078675: the single-item parent-link fixture uses std::slice::from_ref and exact Clippy passed. 7038245733: explicitly inventoried only the cfg(test) router sibling; exact guard and real scoped-reader fixture passed. |
|
PR #14773's |
|
Champion: Holding for Human Merge Judge-approved and passing the mechanical safety criteria, but not
Next steps — this hold stays in force until one of these happens; Champion re-reading the same diff will not clear it:
Keeping Automated by Champion role |
Summary
Verification
Closes #14742
loom dashboard