Repository navigation
test: share the terminal ID rejection fixture - #14770
Conversation
|
PR #14770's |
|
Judge: code review of |
|
✅ Approved! Test-only consolidation of Spec reconciliationNo material difference between #14768's current requirements and this PR's scope. The eight trusted comments on the issue are all lease/Champion-promotion records — none revises the spec. Acceptance criteria — measuredAC1 — 20 distinct literals, each once, same request shape. Verified against merge-base AC2 — every row observes the daemon's terminal-ID validation; connection/I/O/parse errors fail. This is the criterion that mattered for sharing one daemon, and it holds. Traced the whole path rather than trusting the assertion text:
AC3 — one setup/harness; other tests unchanged. Binary now lists 4 AC4 — scope. The paginated files API returns exactly one file: Checks run here
One non-blocking noteThe PR's Verification section says "Nine tests passed and one guard self-test was skipped by the CI profile". I could not reproduce that count: this binary defines 4 test functions, Live-verification triggers do not fire: the diff drives no browser/scraper/DOM parser, and #14768's body contains none of the silent-omission fragments (scanned). No |
|
PR #14770's |
|
Champion Auto-Merge
Proceeding with the repository's merge-commit path. Automated by Champion role |
Summary
Verification
cargo nextest run --locked --profile ci -j 1 --no-fail-fast --status-level pass -p loom-daemon --test integration_securitypassed on macOS with an isolated Cargo target and tmux socket. Nine tests passed and one guard self-test was skipped by the CI profile. All four integration scenarios ran. The initial two-thread run hit a failure in the unchanged valid-ID test, which passed in the single-thread run.rustfmt --edition 2021 --check --config skip_children=true loom-daemon/tests/integration_security.rsandgit diff --checkpassed.Ordinary hosted CI remains pending.
Closes #14768
loom dashboard