Skip to content

fix: skip source-remote lookup on no-op resyncs - #14769

Open
rjwalters wants to merge 1 commit into
mainfrom
feature/issue-14712
Open

rjwalters wants to merge 1 commit into
mainfrom
feature/issue-14712

Conversation

@rjwalters

@rjwalters rjwalters commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Resolve a transferred Loom source remote only on the branch that refreshes the volatile install-metadata stamp. The #11680 no-op decision now happens before the GitHub lookup, so a stale recorded URL can remain byte-identical without a warning claiming it was stamped.

Acceptance criteria

Test Plan

TDD: yes — the new assertions in defaults/scripts/tests/test-resync-installed-stamp.sh reproduced the lookup and false warning on the original code (52/54). All 54 checks pass with the change.

  • Ran the targeted suite with the default Bash and again with macOS Bash 3.2 for both the runner and subprocesses. All resyncs used disposable fixture repos and stub gh.
  • bash -n on both changed scripts and git diff --check passed.

Closes #14712

loom dashboard

@rjwalters rjwalters added the loom:review-requested PR ready for Judge to review. Applied by: Builder when opening PR. label Nov 20, 2026
@loom-fleet-dispatch

loom-fleet-dispatch Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR #14769's loom:reviewing claim is held by the judge of sweep step-judge-14769-1795163173 on host host-3beb8357. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the judge works and released when it is done. Another judge that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

@rjwalters

rjwalters commented Nov 20, 2026 •

Copy link
Copy Markdown
Member Author

PR #14769's loom:reviewing claim is held by the judge of sweep sweep-insession-s38728-ThuNov191721502026 on host host-d9142cf3. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the judge works and released when it is done. Another judge that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

@rjwalters rjwalters added the loom:reviewing Judge is reviewing this PR. Applied by: Judge only. Stale after LOOM_STALE_REVIEWING_MINUTES (30m). label Nov 20, 2026
@rjwalters

Copy link
Copy Markdown
Member Author

Approved on exact head 9df28c97acf7b6562a57d6bca4d88985a51dfd67.

The metadata refresh computes the existing #11680 no-op predicate before making the forge lookup. Both metadata writers keep the recorded volatile fields on that branch, so the already-synchronized consumer retains a byte-identical stamp. A real surface update still resolves the remote through the existing #14243 helper, warns once, and writes the canonical URL. The strong-version, valid-commit and surface-change conditions of the no-op predicate are unchanged. The diff is confined to the resync script and its targeted suite.

Independent offline results from disposable consumers:

  • 54/54 on macOS stock Bash 3.2, including subprocesses, and 54/54 on Homebrew Bash.
  • The new suite against the parent script returned 52/54. The only failures were the discarded GitHub lookup and the false canonical-stamp warning on the no-op path. The real-write control made exactly one lookup, warned once and recorded the canonical URL.
  • Both scripts passed bash -n. The diff passed git diff --check and the exact head combines cleanly with current main. Hosted CI is green on this head and formal review reconciliation is clear.

Git validates the local commit signature. GitHub reports no_user for the same head. The active rules for main contain no verified-signature requirement.

Spec reconciliation

spec=df96ba9c95b34e4c comments=7027239678@2026-11-20T01:12:40Z,7027746123@2026-11-20T01:44:39Z,7030845354@2026-11-20T04:56:34Z,7033847344@2026-11-20T07:59:03Z,7033872416@2026-11-20T08:02:41Z,7033928096@2026-11-20T08:04:43Z,7034000042@2026-11-20T08:08:16Z,7034015315@2026-11-20T08:08:12Z,7034028443@2026-11-20T08:08:49Z,7034105896@2026-11-20T08:12:47Z,7034130024@2026-11-20T08:14:05Z,7034152376@2026-11-20T08:15:18Z,7034216787@2026-11-20T08:18:39Z
baseline: none - no earlier spec baseline available; reviewed against current requirements

loom dashboard

@rjwalters rjwalters added loom:pr PR approved by Judge, ready for Champion auto-merge. Applied by: Judge. and removed loom:review-requested PR ready for Judge to review. Applied by: Builder when opening PR. loom:reviewing Judge is reviewing this PR. Applied by: Judge only. Stale after LOOM_STALE_REVIEWING_MINUTES (30m). labels Nov 20, 2026
@rjwalters

rjwalters commented Nov 20, 2026 •

Copy link
Copy Markdown
Member Author

PR #14769's (no label: the lease is the claim) claim is held by the champion of sweep sweep-insession-s38728-ThuNov191721502026 on host host-d9142cf3. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

@rjwalters

Copy link
Copy Markdown
Member Author

Champion is holding for human merge

The independent Judge approved this head. The no-op path now skips the source-remote query, and the real-write path still checks and records the canonical URL. All 54 checks passed on each Bash version, and required hosted CI is green. Git verified the local signature. GitHub reports no_user, and the target branch rules permit that signature status. Exact Judge approval

  • Blast radius: defaults/scripts/resync-installed.sh controls how the resync updater writes installation metadata and reports its result. Loom's protected updater path applies to this source change. It requires operator disposition.

Keeping loom:pr for the same approved head. An operator can run the repository's pre-merge check and ./.loom/scripts/merge-pr.sh 14769 --release-hold to confirm and merge it.

Automated by Champion role

loom dashboard

@rjwalters rjwalters added the loom:blocked Waiting on something named (another change, a capability); released once it resolves label Nov 20, 2026
@loom-fleet-dispatch

loom-fleet-dispatch Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR #14769's (no label: the lease is the claim) claim is held by the champion of sweep step-champion_merge-14769-1795164536 on host host-d0749b00. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

@loom-fleet-dispatch

loom-fleet-dispatch Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

PR #14769's (no label: the lease is the claim) claim is held by the champion of sweep step-champion_merge-14769-1795168254 on host host-d0749b00. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the champion works and released when it is done. Another champion that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

loom:blocked Waiting on something named (another change, a capability); released once it resolves loom:pr PR approved by Judge, ready for Champion auto-merge. Applied by: Judge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resync: a no-op resync warns that it stamped the canonical loom_source_remote, but leaves the stale one

1 participant