Skip to content

Live verification: session_reconcile creates an App-only private-clone seat after #14744 #14765

Open

Description

@loom-fleet-dispatch

Live run this issue tracks

The fix in #14744 (daemon-owned App gh-config dir no longer refused nor mounted for a NEW private seat) is verified offline by unit tests in loom-daemon/src/tokens_pool/private_workspace/tests.rs. What those tests cannot establish is the live, unattended reconciler pass on a real App-only host.

Someone with access to an App-only crew host (loom-crew-7 / loom-crew-8 class, 2AMLogic/2am#7871, daemon with the #14744 fix deployed) must:

  1. Declare a private-clone seat binding for a repository not yet registered (autonomous.sessionReconcile.privateClones).
  2. Let ONE reconcile pass run (no hand accounts session start).
  3. Confirm:
  4. Close this issue with the observed output.

loom dashboard

Dependencies

Test Plan

  • Record the host, running daemon revision, seat identifier, and UTC time. Choose a logged-in seat with no existing private workspace record or session container. Adding a repository to an existing seat exercises registration and cannot establish fresh seat creation.
  • Declare the binding and capture one unattended reconcile pass. Match its timestamp and seat to the new running container and the session mode shown by loom-daemon accounts list. Run the refusal check below only after collecting this evidence.
  • Confirm the new seat record explicitly contains a null gh_config field (jq -e 'has("gh_config") and .gh_config == null'). Inspect the container’s mount destinations for absence of /run/loom-gh. Use the normal Loom seat execution path to fetch from the declared private repository and record the exit status.
  • For the refusal check, use a separate fresh seat and an existing, empty non-daemon config directory under a disposable checkout. Record the expected refusal text from step 3. Keep credentials outside the checkout.
  • Close with the observed results from the live run. Report only the relevant fields and exit statuses. If a check fails, leave the issue open and identify the failed step.

Affected Files

PR #14766 contains the implementation and offline tests. This issue's deliverable is the evidence comment.

  • loom-daemon/src/tokens_pool/private_workspace/lifecycle.rs resolves the forge configuration directory for a new private seat.
  • loom-daemon/src/tokens_pool/private_workspace/tests.rs contains the corresponding resolution and refusal cases at the PR head above.

Out of Scope

  • Source changes, credential rotation, and migration or removal of existing seats.

Activity

  1. added
    loom:triageNew issue awaiting Curator enhancement. Applied by: humans or any agent filing an issue (intake).
    on Nov 20, 2026
  2. loom-fleet-dispatch commented on Nov 20, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    PR #14765's loom:curating claim is held by the curator of sweep step-curator-14765-1795160843 on host host-a6032f0c. This comment is a PR lease record (#9401): its liveness signal is its own forge-assigned updated_at, renewed while the curator works and released when it is done. Another curator that finds this lease live stands down before touching a worktree. See defaults/docs/lease-record.md § "PR-phase leases".

  3. loom-fleet-dispatch commented on Nov 20, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    Curating this issue per user request.

    loom dashboard

  4. loom-fleet-dispatch commented on Nov 20, 2026

    @loom-fleet-dispatch
    ContributorAuthor

    PR #14766 implements the fix for #14744 and explicitly leaves the crew-host run to this issue. The updated test plan records how to distinguish a new seat from an existing one and what evidence to collect. The PR is still open. Verification can proceed once an App-only host is running the fix.

    loom dashboard

  5. added
    loom:blockedWaiting on something named (another change, a capability); released once it resolves
    and removed
    loom:curatingCurator is enhancing this issue. Applied by: Curator only (claim label).
    loom:triageNew issue awaiting Curator enhancement. Applied by: humans or any agent filing an issue (intake).
    on Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    loom:blockedWaiting on something named (another change, a capability); released once it resolves

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions