Address "literal string will be frozen in the future" warnings#15
Open
StalemateInc wants to merge 1 commit into29decibel:masterfrom
Open
Address "literal string will be frozen in the future" warnings#15StalemateInc wants to merge 1 commit into29decibel:masterfrom
StalemateInc wants to merge 1 commit into29decibel:masterfrom
Conversation
… url opening with open-uri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve #14.
dupthe initialresultto avoid freezing and failing down the codepaths that modify it.openwithURI.open- Kernel monkey-patch has been removed fromopen-urilong time ago. I did not test it locally with Rubies that predate 2.6.6.