Not really rewrite mod system#1072
Not really rewrite mod system#1072SweetSea-ButImNotSweet wants to merge 42 commits into26F-Studio:mainfrom
Conversation
SweetSea-ButImNotSweet
changed the title
SweetSea-ButImNotSweet
changed the title
Not-A-Normal-Robot
left a comment
Not-A-Normal-Robot
left a comment
There was a problem hiding this comment.
just these two things and I think it should be good
|
I would suggest splitting such a large pull request into multiple pull requests, if possible, so that each pull request can focus on a single functionality and be reviewed separately. |
|
To be honest, I want to just close this pull request, but after all, I am not the one responsible for maintaining this repository, and it is kind of disrespectful to do so, so I would just wait. |
Not-A-Normal-Robot
left a comment
Not-A-Normal-Robot
left a comment
There was a problem hiding this comment.
code lgtm, but yeah next time I suggest you to split different changes to different PRs
I am doing it right now T_T |
SweetSea-ButImNotSweet
changed the title
Not-A-Normal-Robot
left a comment
Not-A-Normal-Robot
left a comment
There was a problem hiding this comment.
I skimmed through the code, LGTM
| for _=1,20 do | ||
| coroutine.yield() | ||
| end |
There was a problem hiding this comment.
I think there's a TEST.yieldN() thing you could use instead. @MrZ626 would you recommend using that, or is that just a temporary thing?
MrZ626
force-pushed
the
main
branch
2 times, most recently
from
33e873c to
4768df6
Compare
3 participants
Resolve #1064
TODO:
P/S: Playing the replay which applied the mods after the initialization or always during game in older version may lead to desynchronization.