Repository navigation
Preserve evidence integrity and commit goal proofs atomically - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed single/batch
record_factinput silently discarded the top-level fact, whileprove_goalcould report success after a failed graph write and could omit goals beyond the latest 1000. Validate fact input before any write or audit consumption, and commit evidence authorization, proof edges, goal state and complete goal counts in one PostgreSQL transaction. Tool completion flags change only after a successful commit. Preserve legacy single receipts and ordered partial-success batch receipts.Acquire task/source locks before exploration and node locks to preserve task-deletion lock ordering. Keep one-hop live source authorization and revalidate nodes under lock. Natural-language goal acceptance and concurrent post-commit goal changes retain their existing contracts.
Resolve GHSA-mrhx-c7xc-m3w5 by updating the frontend and recon lockfiles to Zod 4.6.6 within their existing dependency ranges. Both dependency audits report zero vulnerabilities; frontend type checking and 230 unit tests pass, and recon tests report 10 passes with two existing Chromium skips.
Keep covered facts visible when a cold-graph query fails, and make budget/turn termination receipts refer to actual tool write receipts. These two narrow adaptations follow RuochenPan / RC-CHN's
055c06dfand210a4a66, AGPL-3.0. Source attribution and behavior are documented indocs/fork-integrations.mdanddocs/evidence-provenance.md.Validation:
agentanddbpackage tests with-race -count=1passed against separate fresh PostgreSQL 16 databases; the live-model review test was explicitly excluded.git diff --checkpassed.All local runtime verification uses isolated databases and existing local code. No model, paid-provider or real-target requests were made. Exact-HEAD quality and CodeQL checks are required before normal merge.