Repository navigation
Conversation
fix: apply persisted settings through the real game HUD
2002yy
changed the title
2002yy
marked this pull request as ready for review
October 20, 2026 17:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecd582d112
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the project and native test workflow to Godot 4.7.1 and connects persisted settings to the real Main/HUD flow. Performance and event-log preferences apply at startup and on user changes; refreshing the settings panel does not emit fake changes. Editing performance or low-effects preserves an event log manually collapsed through the HUD. Event history is preserved.
Base: main (7c0a426). Current head: 1f8d19b. The original settings fix #8 is included and the collapse review finding is fixed and resolved. Existing main runtime/document moves are preserved. Gameplay, save schema and event effects are unchanged.
Validation: all 12 native Godot runners pass in isolated user directories without SCRIPT ERROR/ERROR. SettingsAndResult has 40 passing assertions; the collapse regression fails on the old implementation. Current-head PR CI 39554106580 completed successfully. CI uses the official 4.7.1 Linux asset, isolated per-runner profiles and explicit script-error rejection before accepting PASS. Android export/signing and long-duration performance qualification remain outside this change.