Skip to content

fix(windows): polish title bar and loading icons - #971

Draft
xtr-hub wants to merge 1 commit into
1lck:previewfrom
xtr-hub:fix/windows-icon-polish
Draft

xtr-hub wants to merge 1 commit into
1lck:previewfrom
xtr-hub:fix/windows-icon-polish

Conversation

@xtr-hub

@xtr-hub xtr-hub commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Use the native Windows caption glyphs for minimize, maximize, restore, and close; map command-palette window actions to their matching icons; and remove title-bar right padding so the close hover background reaches the window edge.
  • Replace the Updates settings category's refresh arrow with a download icon.
  • Standardize loading feedback on the shared LoaderCircle spinner, including toast loading and Git staging; all shared Spinner call sites receive the update.
  • Add window controls to the cross-platform feature matrix and regenerate its Markdown and CSV views.

Validation

  • bun run typecheck (windows/tauri)
  • bun run lint (passes with existing warnings)
  • bun run build (windows/tauri)
  • scripts/verify-platform-feature-matrix.sh
  • scripts/verify-platform-feature-matrix-change.sh upstream/preview HEAD
  • Runtime bundle scan: zsh is unavailable in this Windows environment, so the equivalent PowerShell scan passed with no violations.

@ghfind-review ghfind-review Bot added the review: medium ghfind author score; see https://ghfind.com label Sep 28, 2026

@xiaoyumuxi xiaoyumuxi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有两个 P2 建议先处理:

  1. 命令面板窗口动作目前没有真正接通窗口 API。
    window-actions.tsx 里的 minimize-window / maximize-window / toggle-fullscreen 都只是 dispatchEvent,仓库里没有对应的窗口级 listener;实际点击后只会关闭命令面板,不会调用 Tauri 的窗口操作。建议直接复用 window-menu-bar.tsx 已有的 getCurrentWindow().minimize()/maximize()/setFullscreen() 路径,或补统一的 window-event bridge。否则这次新增的 window-controls 功能矩阵不应把 Windows 标为 implemented。

  2. Maximize / Fullscreen 的图标和标签没有跟随当前窗口状态。
    这次把图标改成了更明确的 maximize / fullscreen 图标,但 createWindowActions() 不接收 isMaximized / isFullscreen。窗口已经最大化时仍显示 Window: Maximize 和 maximize 图标,而描述又写了 “Maximize or restore”;全屏时也仍显示进入全屏图标。PR 新增的矩阵验收要求“最大化/还原状态与按钮标签一致”,按当前结构无法满足。建议注入窗口状态动态生成 Restore / Exit Fullscreen 的 label/icon,或者把 Maximize 定义成纯 maximize 而不是 toggle。

其余标题栏 glyph、右侧 padding、共享 Spinner 和 Updates 图标改动静态看没有发现明显回归,当前 CI 也全绿。

另外 PR 当前 mergeable: false,基线 preview 已前进,冲突主要落在功能矩阵 JSON / Markdown / CSV。建议先同步最新 preview,以 JSON 为准解决后重新生成文档并再跑一轮 CI。

@xtr-hub
xtr-hub marked this pull request as draft September 29, 2026 04:45
@xtr-hub

xtr-hub commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

我现在正在调整这个图标,忘记给pr改成草稿了,添麻烦了,后续我会补上UI具体变更图片

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review: medium ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants