fix(macos): 修复 Agent 对话入口闪退并改进侧栏图标 - #965
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题与改动
Lithe 0.5.6(41)点击 Agent 对话入口时,品牌图标加载直接访问 SwiftPM 的
Bundle.module。发布包把资源放在Contents/Resources/Lithe_Lithe.bundle,而生成的访问器查找 app 根目录和 CI 构建目录,找不到便触发致命断言。Contents/Resources/Lithe_Lithe.bundle只读加载 Codex/Claude 图标;已安装.app缺少资源时返回默认图标,不再调用会终止进程的开发资源访问器。.app开发与测试入口的 SwiftPM 回退,图像缓存加入资源包身份,防止不同资源包串用图像。验证
./.agents/skills/write-stable-tests/scripts/test-stability-macos.sh --report .artifacts/test-stability/agent-icon-regression.json -- --filter Agent:通过;Swift runner 报告 77 项测试通过,计时报告记录 76 个测试条目,新增两个测试分别耗时 12ms、1ms。./scripts/test-macos.sh --filter 'AgentBrandIconResourceTests|WorkbenchModuleUIRegistryTests':8 项通过。origin/preview的矩阵变更门禁均通过。.app预览;用户确认 Agent 对话正常打开。新入口图标已在深浅背景及蓝色选中态渲染检查,并随预览包启动。Lithe Review
结论:未发现需要阻塞合并的问题。 按仓库
.agents/skills/lithe-code-review/SKILL.md审查本分支相对preview的 9 个相关文件及其直接调用链,覆盖需求完成度、资源查找与缓存、失败回退、只读发行边界、测试清理、资源许可归属及文档一致性。没有需修正的实质性发现。范围限制:本次仅修改 macOS 图标与资源加载;未运行完整 macOS 测试套件、Windows 运行验证或真实 Claude 端到端对话。功能矩阵保留相关完整功能的待验证状态;GitHub CI 以 PR 检查结果为准。