fix(macos): 修复中文组合输入层透出原文字的重影 - #1010
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS 中文候选输入时,Monaco 的临时输入框直接使用只有约 3.5% 不透明度的当前行高亮色,导致下方已渲染文字透出,形成整行重影。本次为组合输入层提供不透明底色,并在其上叠加编辑器背景和当前行高亮;输入结束后恢复普通输入样式。
验证:
bun macos/EditorFrontend/build.ts与bun macos/Experiments/Monaco/build.ts frontend/editor/node_modules/monaco-editor --workbench-tests成功。验证限制:当前机器是 Linux,未运行 macOS AppKit/WebKit 原生宿主或系统输入法。仍需在 macOS 使用系统拼音/微信输入法验证候选输入、候选删减、上屏后删除、撤销和分屏;本 PR 不声称已实机复现并消除全部删除重影。
按仓库
lithe-code-reviewSkill 完成自审:修正上述测试入口覆盖缺口,最终未发现需要阻塞合并的问题。原生输入法与 WebKit 绘制验证仍保留为信息缺口,不以 Chromium 结果替代。