Support timeout values in client::register() and client::authenticate()#94
Support timeout values in client::register() and client::authenticate()#94Brisk4t wants to merge 4 commits into
Conversation
|
Updated the CI and crate toolchain version to @Progdrasil I can make this a different PR in case you want to merge just the CI updates without the workflow checks since it will fail those until the toolchain update applies. |
| license = "MIT OR Apache-2.0" | ||
| repository = "https://github.com/1Password/passkey-rs" | ||
| rust-version = "1.85.1" | ||
| rust-version = "1.86.0" |
There was a problem hiding this comment.
yeah, that's fine, we're at 1.94
There was a problem hiding this comment.
Do we wanna bump the version all the way to 1.94 then? Or do we want to stick to minimal functional updates?
Having it in this PR is fine for me, I just want to make sure this doesn't break for others downstream. |
Implements #65.
Not sure how much we care to keep tokio optional but guarded it just in case. I doubt there are any no_std implementations of this since both
authenticate()andregister()functions are async by default.Note on updated
rust-toolchainfile:I changed
1.85.1tostablesince i was getting version errors withicu_*andidna_adapterwhile building with the existing 1.85.1 but if we need to keep it pinned I could just make it 1.86 (which is the lowest supported version for those two crates), builds fine with stable though 🤷