Skip to content

Support timeout values in client::register() and client::authenticate()#94

Open
Brisk4t wants to merge 4 commits into
1Password:mainfrom
Brisk4t:main
Open

Support timeout values in client::register() and client::authenticate()#94
Brisk4t wants to merge 4 commits into
1Password:mainfrom
Brisk4t:main

Conversation

@Brisk4t
Copy link
Copy Markdown

@Brisk4t Brisk4t commented May 17, 2026

Implements #65.

Not sure how much we care to keep tokio optional but guarded it just in case. I doubt there are any no_std implementations of this since both authenticate() and register() functions are async by default.

Note on updated rust-toolchain file:

I changed 1.85.1 to stable since i was getting version errors with icu_* and idna_adapter while building with the existing 1.85.1 but if we need to keep it pinned I could just make it 1.86 (which is the lowest supported version for those two crates), builds fine with stable though 🤷

@Brisk4t Brisk4t marked this pull request as draft May 17, 2026 23:21
@Brisk4t Brisk4t marked this pull request as ready for review May 19, 2026 19:07
@Brisk4t
Copy link
Copy Markdown
Author

Brisk4t commented May 20, 2026

Updated the CI and crate toolchain version to 1.86.0 which is the minimum required version for crate deps failing in the build.

@Progdrasil I can make this a different PR in case you want to merge just the CI updates without the workflow checks since it will fail those until the toolchain update applies.

Comment thread Cargo.toml
license = "MIT OR Apache-2.0"
repository = "https://github.com/1Password/passkey-rs"
rust-version = "1.85.1"
rust-version = "1.86.0"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iinuwa is this change okay on your side?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's fine, we're at 1.94

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we wanna bump the version all the way to 1.94 then? Or do we want to stick to minimal functional updates?

@Progdrasil
Copy link
Copy Markdown
Collaborator

Updated the CI and crate toolchain version to 1.86.0 which is the minimum required version for crate deps failing in the build.

@Progdrasil I can make this a different PR in case you want to merge just the CI updates without the workflow checks since it will fail those until the toolchain update applies.

Having it in this PR is fine for me, I just want to make sure this doesn't break for others downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants