Skip to content

add generated media download timeouts#6382

Closed
zhonggang666 wants to merge 1 commit into
1Panel-dev:v2from
zhonggang666:codex/split-fix-media-download-timeout
Closed

add generated media download timeouts#6382
zhonggang666 wants to merge 1 commit into
1Panel-dev:v2from
zhonggang666:codex/split-fix-media-download-timeout

Conversation

@zhonggang666

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

Adds explicit timeouts and HTTP status checks when generated media workflow nodes download remote image/video URLs.

Closes #6370.

Summary of your change

  • Adds a generated media download timeout constant.
  • Uses requests.get(..., timeout=...) for generated remote media URLs.
  • Calls raise_for_status() before saving the downloaded media bytes.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

Validation:

  • python -m py_compile apps/application/flow/step_node/image_generate_step_node/impl/base_image_generate_node.py apps/application/flow/step_node/text_to_video_step_node/impl/base_text_to_video_node.py apps/application/flow/step_node/image_to_video_step_node/impl/base_image_to_video_node.py
  • git diff --check

@zhonggang666 zhonggang666 force-pushed the codex/split-fix-media-download-timeout branch from dcb07bf to 7e468bf Compare July 9, 2026 09:27
@zhonggang666 zhonggang666 marked this pull request as ready for review July 9, 2026 13:16
@zhonggang666 zhonggang666 changed the title [codex] add generated media download timeouts add generated media download timeouts Jul 9, 2026
@liuruibin

Copy link
Copy Markdown
Member

没有修改计划

@liuruibin liuruibin closed this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Media generation workflow nodes download remote files without a timeout

2 participants